Graphite Community

Thanks for the flag! Tested this on my end and it seems to be fine - DM me a screen recording?

Screenshot 2023-05-02 at 11.30.58 AM.png

Sorry you're running into this! Is your stack based on the default branch?

fwiw I wasn’t encountering a problem with stack merging last week, and we haven’t changed our required status checks since then

What is the expected behavior here, that CI doesn't run until you trigger the merge?

&gt; CI doesn’t run until you trigger the merge?
not exactly - the expectation is that it doesn’t run until the PR’s base branch is set to the default branch. Essentially, this is a cost saving strategy to minimize unnecessary runs

I would expect
1. Graphite allows me to enqueue the stack merge if the required status checks according to GitHub are passing (i.e. it respects how required status checks have been configured in the branch protection rules for the current base branch of the PR)
2. when the base branch is merged into the default branch and the “current’ feature branch’s base is switched to the default branch, then GitHub will consider the check to be required and trigger it (if needed)

for now, I’ve managed to work around this issue by setting our github workflow to trigger regardless of the PR’s base branch, and have the jobs in the workflow skip (i.e. no-op)

looks like Graphite is happy now that a status (of skipped) is being reported

Screenshot 2023-05-02 at 3.43.57 PM.png

How are the filters configured for this section? (gear  on the upper right corner)

Looks like this section has no filters/the default filters have been cleared?

To reset your sections to the default filters you can delete all of the sections and then it will give you the option to recreate them from scratch

image.png

Sorry about this - we're looking into it!

<@U02E95J4648> shipped a fix for this yday!! :saluting_face: let us know if you see more issues!

<@U04K5N14V9B> I can see all PRs on my dashboard as before so the fix worked, however, the section that shows merged and currently merging PRs is now broken. I haven't change anything and I'm still using the default filters (see screenshot), however, this section doesn't show any queued PRs for merging. I just initiated a stack to be merged and every refresh of the dashboard I can see that a new PR was merged in that section but the rest of PRs from that stack are still in the "Waiting for reviewers" section. PRs from the stack are only moved from that section only when they are fully merged :eyes:

hey! thank you for the feedback -- im really sorry that the update has made it harder for you to use Graphite

we understand your concerns around accessibility and know that the current dashboard has a lot of room for improvement, and we're working on revamping the entire experience in the coming weeks with a focus on readability and usability that should hopefully help resolve these issues

thank you for bearing with us as we iterate here :pray: 


i know this isn’t the answer you’re looking for, but in the meantime we’ve also added better navigation to the threads in PRs — `shift+up/down` will now let you toggle between all of the threads (or click on the comment icon in the header) to quickly jump to each thread in the diff view

ooh nice i’ll check that out! thanks for the tips :slightly_smiling_face:

it should say that _sending_ messages to the bot is turned off — is that what you’re seeing?

you can also test your slack configuration by turning real-time notifications off and on again (you should get a slack message from the bot for each of those actions)

lmk if you see any issues there and i can debug further!

Yep you’re right about the message, red herring

Graphite - Slack notifications are flaky ​*[Identified]*​ We are continuing to work on a fix for this incident.
 ​*Affected:*​
Notifications
 View incident button

Graphite - Slack notifications are flaky ​*[Monitoring]*​ We implemented a fix and are currently monitoring the result.
 ​*Affected:*​
Notifications
 View incident button

Graphite - Slack notifications are flaky ​*[Resolved]*​ This incident has been resolved.
 ​*Affected:*​
Notifications
 View incident button

has happened a couple times over the past week or so

(but happens even when there's not a github outage)

hey! it looks like your slack app doesn't have the latest permissions -- could you try reinstalling it?

will look, is this just clicking on graphite -&gt; configuration -&gt; remove app?

you should be able to go to <https://app.graphite.dev/settings/notifications> and re-add your slack workspace in the first dropdown to trigger the oauth flow!

ah nice, ill let you know if that worked next time it says "review in thread below"!

<@U04AP0M9AES> sadly still seems to happen:

hmmm it’s possible that something more nefarious is going on — i’ll take a look!

lmk if want me to still upload examples in case it helps u repro

thanks! will let you know but we should have logs that'll help pin this down :slightly_smiling_face: 

hey! sorry for the long wait here — i just got back from vacation and had a chance to dig into this for you, and i think i’ve found the issue+pushed a fix which should resolve this :tada:

sweet! let us know if you have any other problems :slightly_smiling_face:

<@U04AP0M9AES> looks like this is broken once more :disappointed:

looking! for context -- this usually happens when we try to send you some rich/large content in the pr description that the slack api doesn’t like

i’ll take a look and clean that up on our end, but it may take a few days for me to get to this

Can confirm that merge failures currently are due to this outage

heads up, github is down right now: <https://www.githubstatus.com/>

the error was shortly after I clicked the stack merge button

cc <@U02RREE9GKH> and <@U0486U7UUF3> - thanks for letting us know!

CleanShot 2023-05-05 at 10.52.36.mp4

1. Agh this is a known issue - we'll create a fix for this ASAP!
2. Hmm this is interesting, we'll look into it!
3. Noted :slightly_smiling_face:

(As a workaround for number one, you can hit plus first which will temporarily fix our buggy typeahead)

mm, thanks for flagging this case!! we'll look into it

🥲.mov

mentioned this in a thread below as well, but we're thinking about hiding it while you're editing another comment!

you could also reduce the hit area to just the submit review button as another suggestion

we’ll be doing that too :slightly_smiling_face:

CleanShot 2023-05-06 at 10.35.47@2x.png

[Keyboard Shortcuts]
• The list of available shortcuts is missing the ⌘+↑ and ⌘+↓ shortcuts for jumping between files
• It would be great to have a shortcut for marking the currently focused file as viewed
• The next/previous shortcuts wrap around from top -&gt; bottom and bottom -&gt; top which is a little disorienting. I think it would be great if there was some amount of friction point there (like hit twice quickly to go around or maybe jump to top/bottom)

we're thinking about hiding it while another comment is being edited!

Hmm thanks for flagging! We'll look into this

Thanks for flagging! We'll create a ticket for this

My colleague keeps getting this error when trying to collaborate on my branches following the instructions in the docs.  Any idea what could cause it?

He says it only happens when the branch is not the most downstack branch in a stack

Thanks for the feedback - we're looking to improve this experience in the next few days! Understand how frustrating this can be, and definitely want to get it resolved asap

This happens when viewing a subset of changes

And a possible hint: the viewed buttons sometimes doesn’t have a checkbox

Clicking any “Viewed” button (regardless of checkbox status) crashes the page (screen turns dark grey, no other UI on the page)

This happens more often for me when viewing the diff for a version other than latest 

In my case I was viewing 4-10, and 10 was the most recent

Ah yeah it also happens more often for me if I select the left version to be anything other than base

Though I can get it to happen for the default diff as well

hey all, this should be fixed now!
marking a file as viewed is just not supported at this time when on a version compare view, so i modified the button to be disabled and show a tooltip when you're in this state

Hm, loads for me - sorry you’re hitting this though, could still be a real bug

started loading now, but will report back if it comes back

oh weird, i was just typing a comment and the page went blank to some new loading state

oh, is datadog necessary for functionality? seems like an adblocker or something is blocking it on my end

that's weird, it loads fine for my coworkers

Screenshot 2023-05-09 at 9.29.27 AM.png

Screenshot 2023-05-09 at 9.29.04 AM.png

There is issue with GitHub <https://www.githubstatus.com/>

Fyi, GitHub is having an incident right now! Might affect some Graphite actions
<https://www.githubstatus.com/>

Hmm weird, sorry about that! Does this PR have a # of required reviewers &gt; 1?