https://grails.org/ logo
Join Slack
Powered by
<https://allthingsopen.org/articles/migrating-open...
# general
j
j
Removing 1.2 million lines of code surprised me.
How many lines are left?
j
@jdaugherty do you remember those stats, my memory is a bit rusty in that area. But we did leave the important lines.
j
I think we generated those stats based on the git diffs
In one of the consolidation tickets, I think we put the script that checked that
There were several things we have removed, including: 1. there was forked code from spring around annotation handling in gorm (we were able to adopt the upstream code and remove the fork) 2. gradle - there was a significant amount of duplication across the builds & we simplified them rather heavily 3. adopting the groovy json stuff instead of the forked versions 4. there was a bunch of interop workflows b/c the repos were separate, so code was often duplicated Overall, I seem to remember most of those diffs being the result of the consolidation and not specifically Grails "shipped" code. But it was still code that was removed.
j
And a chunk of them were generated items that were checked in, like a full copy of docs from Grails 3 and similar items.
j
Right, forgot about all of teh old dead BuildSettings stuff
there was a lot of legacy code that was "dead" that needed removed
j
Tbh I misread and thought it said 1.2 million lines of code were removed. That is not what it says.
Open in Slack
PreviousNext
Powered by