A complete solution for open data platforms, enterprise data catalogs, data lakes and data management. Open source, mature, fully-featured and production ready.

DataHub

Can anyone review my PR fixing redash dashboard url bug?
<https://github.com/datahub-project/datahub/pull/5500>
Thanks!

<@U039CSMRRU4>: could you confirm my comment?

<https://github.com/datahub-project/datahub/pull/5500#discussion_r939843632>

it seems like the url that would be generated would look like:
```&lt;self.config.connect_uri&gt;/dashboards/{dashboard_data.get('id')}-{dashboard_data.get('slug', '')}```


so something like `dashboards/3-&lt;slug&gt;`

have you tested that it works with the `slug` as the suffix?

and when slug is not present it will be `dashboards/3-` with the dangling `-` at the end

should it instead be:
if slug is present dashboard url should be `{uri}/dashboard/&lt;slug&gt;` and if slug is not present then dashboard url should be `{uri}/dashboards/dashboard-id`

<@UV0M2EB8Q>
Thanks for the code review. I understand my code break older versions of redash. So, fix the logic to maintain backward compatibility and push my code. Would you review <https://github.com/datahub-project/datahub/pull/5500> again?