Hello team! From Adevinta, we have created a <PR> ...
# contribute-code
c
Hello team! From Adevinta, we have created a PR to generate data platform instance aspect for bigquery v2 using the project id value .Could you please review whenever you have time? Thank you! cc @microscopic-honey-35198
f
Hi Adrian, I merged this earlier this week but am curious on the motivation for this change. I'm realizing it may be inconsistent to create a platform instance aspect but not generate urns based on the platform instance. This may also conflict with the new browse path feature we're building.
Unfortunately going to have to revert the change due to the concerns above 😞, sorry! If you are trying to mark data by project, we suggest using the
SimpleAddDatasetDomain
to set the domain for each dataset to its project.
c
Hi @famous-waitress-64616, apologies for the late reply. From our side it is needed so we can assign ownership to the platforms and have privileges applied to resource owners based on platform instance, even though this change is still pending. There was a previous discussion about this change with Shirshanka and we got an ok as the change it is align with bigquery entities following a similar approach that other sources use and therefore have a standardization of the model. We hope this context is enough to keep the change, let us know if you need anything else
a
Thanks for the clarification. While we recently merged the revert, I'll make sure we find a resolution for your use case in a timely manner, whether that be adding back platform instances to the bigquery source or something else.