https://discord.cloudflare.com logo
Join Discord
Powered by
# r2
  • i
    Oh yeah, for sure 🙂
  • p
    fingers crossed that we have access to it before the R2 demo on saturday 🤞
  • v
    @cloudflare/workers-types@3.5.0 is published
  • v
    it has R2 bindings
  • j
    thanks!
  • j
    include
    should be optional, right?
  • v
    Yup. A bug in the workers types. It’s actually optional. Will get that updated
  • l
    Hmm, from the looks of it, you guys are having a lot of trouble with r2, I wish you all a great day and that everything works out smooth ||(and that there are no errors :))||!
  • k
    i mean, looks like normal beta stuff
  • l
    ye
  • l
    agree
  • v
    It mostly feels pretty smooth on my end which isn’t good if that’s not what our users are seeing. What trouble are you experiencing?
  • l
    I expect no trouble
  • l
    I'm wishing everything goes fine
  • s
    aaaahhhh, still no dashboard/API access
  • v
    @john.spurlock 3.5.1 should have the fix for 
    include
    to be optional & for the put to accept a 
    Blob
    too.
  • j
    what does putting a 
    null
    value do? Is it the same as a delete? Or does a subsequent get return a zero-byte body?
  • j
    also these should probably be 
    readonly
  • v
    The latter
  • v
    Why?
  • j
    in return positions only, not mutated for subsequent upload or anything
  • j
    also just out of curiosity, why is 
    R2Object
    an abstract class vs an interface?
  • v
    Not sure I follow. Typically the runtime only marks fields as 
    readonly
    when they correspond to a view of some key internal state that we don't let you modify. This returned result isn't used by us for anything - you're free to modify it if you like
  • v
    It's done that way because 
    R2Object
    is inherited by 
    R2ObjectBody
    . 
    R2Object
    is what you get from `list`/`head`, 
    R2ObjectBody
    is what is returned from 
    get
    . Would interfaces actually work here?
  • j
    yep, a ts interface can extend another interface - for what is essentially idl I would prefer an interface, so mockers don't have an arbitrary class constraint
  • j
    just curious as I see it's used elsewhere outside of the r2 stuff
  • v
    Probably just a leakage in terms of how our automatic type generation works
  • v
    I'm not sure it's an easy thing to change
  • j
    ah ok if its a pure data structure that can has no internal bookkeeping, makes sense to relax these
  • j
    here are microsoft's types for the dom as an example - all interfaces, even for subtypes: https://github.com/microsoft/TypeScript/blob/main/lib/lib.dom.d.ts
1...323334...1050Latest