Another option, if all of your static assets like images/css, etc. are in a single folder like

assets

, you could exclude that folder from running any functions using `_routes`: https://developers.cloudflare.com/pages/platform/functions/routing/#functions-invocation-routes

Hey all! I am just making a simple landing page for a school simulation project, but I can't seem to get functions to work/build correctly. In the building of the pages it shows:

Found Functions directory at /functions. Uploading.
12:36:37.272    
12:36:37.386    ✘ [ERROR] No routes found when building Functions directory: /opt/buildhome/repo/functions
Warning: Wrangler did not find routes when building functions. Skipping.
12:36:37.400    Found _routes.json in output directory. Uploading.
12:36:37.423    Validating asset output directory

I have attached the KV namespace to the project for the function, but it seems like it just won't build the function at all. Functions folder is created and _routes.json is present.

unfortunately not; images/pdfs are among the html files

I'll try the content-type thing

@James content-type seems to work fine. no issues or performance impact

using

indexOf

to see if

text/html

is in there

although if the response is just

text/html

I could probably do an equality comparison

it'll likely include a charset too - doing an inlcudes check is what I'd do

it sometimes has a charset

that

okay switched to includes. works too

Is there some way to write a middleware that only applies to pages routes? Im using HTMLRewriter, and it would be great if i could avoid triggering the middleware from static assets and api routes.

Doesn't middleware only run on Function routes that already exist anyway?

Not sure if this is for #910978223968518144 or #992060581832032316 I'm exerpiencing a weird error but i'm not quite sure what is wrong. I might just not be good enough to understand what the error is saying. It only seems to break when I use prepared statements (the error happens on the bind() part) Error:

js
Error: Type 'function' not supported for value 'function(block) {
      return block(this);
    }'

Code

ts
let prepare = this.DB.prepare("INSERT INTO users (email, password, salt, id) VALUES (?, ?, ?, ?)");
let command = prepare.bind(email, password, salt, id);

That error seems to hint that one of the variables you're passing in your .bind() call is a function

all of them are strings, i promise

All that D1's code is doing to get that error is a typeof check

If you want to be sure, you can .toString() all of your variables

Just tried it now, still the same problem.

That's the only place in the entire codebase that throws that error 🤔

Could you share the entire code so I can have a look?

These should be the relevant ones

ts
export interface Env {
    DATABASE: D1Database;
    PEPPER: string;
}

ts
export class UserDB {
    DB: D1Database;

    constructor(db: D1Database) {
        this.DB = db;
    }

    async createUser(email: string, password: string, salt: string, id: string): Promise<User> {
        console.log("preparing command")
        let prepare = this.DB.prepare("INSERT INTO users (email, password, salt, id) VALUES (?, ?, ?, ?)");
        let command = prepare.bind(email.toString(), password.toString(), salt.toString(), id.toString()); // Throws here
        await command.run();
        return await this.getUser(id)
    }
}

ts
export const onRequestPost: PagesFunction<Env> = async (context) => {
    let {email, password, challenge} = await context.request.json<{
        email: string, password: string, challenge: string
    }>();
    
    // Validation here

    let db = new UserDB(context.env.DATABASE)
    
    let salt: string = Buffer.from(crypto.getRandomValues(new Uint8Array(16))).toString('base64');
    let id: string = uuidv4();
    let hashedPassword: string = SHA512(salt + password + context.env.PEPPER).toString(CryptoJS.enc.Hex);
    let result = await db.createUser(email, hashedPassword, salt, id); // Throws here
}

Those all are definitely strings.. how odd 🤔

Is it still the same

function(block) {
      return block(this);
    }

in the message, even with the .toString()?

Yes

Is this deployed code or local testing?

deployed in pages, yes

This is a function

Alright, can you make an issue at https://github.com/cloudflare/workers-sdk/issues/new/choose

Will do