or do I just need to restructure my api so all endpoints requirnng auth are inside an

auth

folder or smth? Doesnt seem super clean that way though

is there anyway to define a list of routes (including the params) that the middleware will apply to?

I could just put middleware on root, and just if url matches do stuff else continue, but that will run the worker for eveyr request which is not needed and idk what I would do about params?

You can expose an array of handlers in your onRequest code, for example.

js
export const onRequestGet = [myMiddlewareHandler, myRouteThatShouldHaveMiddlewareFirst]

That way, you can explicitly choose which routes it runs on

If I haven't misunderstood it, this appears to explain how to connect to the worker with WebSockets, not connecting to a WebSocket server from the worker.

Ah, I completely glanced over that. But so the constructor is supported then. Since when? Cause it could be that I have an old version of wrangler then and that's why it's giving me the error that the constructor is not implemented.

Oh, are you using TypeScript?

Yeah, in addition to that, I am using a library (surrealdb.js) that establishes the connection with the WebSocket() constructor.

Do you have https://npmjs.com/package/@cloudflare/workers-types added to your

tsconfig.json

?

Yes, I'm getting this error during runtime

ERROR Error: Failed to construct 'WebSocket': the constructor is not implemented.

I'll try to update to the latest version of wrangler/miniflare and try again

the constructor is not implemented

is something thrown by the runtime

What's your

compatibility_date

in your

wrangler.toml

?

WebSocket

isn't a recent addition, but if your compat date is really old, it might not be there...

I added it today due to the warning, but I pass it in the CLI as

--compatibility-date=2023-01-29

Your code is using

new WebSocket

- which is not implemented. The guide you were linked explains how to create websockets in the workers runtime

I thought for a while it has been supported, even miniflare got a PR recently that added support https://github.com/cloudflare/miniflare/pull/466

(for clients, the pair stuff is still needed for letting external clients connect to DOs, for example)

I can't find any explanation for why the unimplemented error is returned

the constructor doesn't have

jsg::unimplemented

or

wontimplement

- but that is what'd throw the error

perhaps thats the default behaviour of v8/js when it's not implemented?

It's thrown from workerd

I see, would it be possible to implement it through the prototype myself? I'm thinking about doing something like this as described in the docs about websockets:

js
  let resp = await fetch(url, {
    headers: {
      Upgrade: 'websocket',
    },
  });

  let ws = resp.webSocket;
  if (!ws) {
    throw new Error("server didn't accept WebSocket");
  }

  ws.accept();

The

WebSocket

constructor should work fine: https://developers.cloudflare.com/workers/learning/using-websockets/#writing-a-websocket-client If It doesn't, I would recommend filing an issue on the

wrangler2

repo

> Cloudflare Workers supports the

new WebSocket(url)

constructor.

Yeah I saw it, weird. I wonder why I'm getting this. Let me try to clean things up and try again. Made an issue: https://github.com/cloudflare/wrangler2/issues/2640