https://discord.cloudflare.com logo
Join Discord
Powered by
# functions
  • c
    I think it should be this guy here https://pvp-legacy-api.pages.dev/
  • w
    ty
  • w
    Could you try to rename your functions folder to like 
    functions-disabled
    and push? Wondering if it is the function maybe causing this failure
  • w
    It shouldn't be... but worth a shot
  • c
    I'll give it a shot
  • i
    Not really sure... if it helps, I had to rename my functions folder to _functions because it was causing issues originally.
  • c
    @User it did deploy
  • w
    Right so it seems it was the function..
  • w
    hmm
  • c
    I'm gonna rename it back and try, just as a sanity check
  • c
    ._. I think I fixed it
  • c
    I'm gonna see if I can undo it and break it again
  • c
    nope, no idea
  • c
    very cool
  • p
    I'm playing with pages advanced mode (so _worker.js file basically) and javascript modules. However it doesn't seem to be working after I try to import module. Am i doing something wrong?
    Copy code
    // _worker.js
import { add } from "./add";

export default {
  async fetch(request, environment, context) {
    if (request.url.includes("/api/")) {
      console.log("worker", request.url);

      const count = add(2, 3);

      return new Response(count);
    }
    console.log("static", request.url);

    return env.ASSETS.fetch(request);
  },
};


// add.js
export function add(a, b) {
  return a + b;
}
  • p
    Error:
    Copy code
    VMScriptRunnerError [ERR_MODULE_RULE]: Unable to resolve "_worker.js" dependency "./add": no matching module rules
    at ModuleLinker.linker (file:///opt/homebrew/lib/node_modules/wrangler/node_modules/@miniflare/runner-vm/dist/src/index.js:59:13)
    at ModuleWrap.<anonymous> (node:internal/vm/module:312:30)
    at SourceTextModule.<computed> (node:internal/vm/module:311:36)
    at SourceTextModule.link (node:internal/vm/module:197:22)
    at VMScriptRunner.runAsModule (file:///opt/homebrew/lib/node_modules/wrangler/node_modules/@miniflare/runner-vm/dist/src/index.js:220:18)
    at VMScriptRunner.run (file:///opt/homebrew/lib/node_modules/wrangler/node_modules/@miniflare/runner-vm/dist/src/index.js:242:28)
    at EventTarget.#reload (file:///opt/homebrew/lib/node_modules/wrangler/node_modules/@miniflare/core/dist/src/index.js:1797:42) {
  code: 'ERR_MODULE_RULE',
  cause: undefined
}
  • g
    Single Worker scripts only support a single compiled file at the moment, so you'll need to bundle that yourself.
  • g
    Yup, I recommend esbuild
  • p
    Gotcha, I think I missed that
  • g
    esbuild src/index.ts --bundle --outfile=dist/_worker.js --format=esm --minify
  • g
    you have an extra 
    --bundle
  • g
    (Assuming build directory is 
    dist
    and you have 
    index.ts
    and 
    app.ts
    in 
    src
    )
  • p
    Works! Thanks guys
  • p
    Do you have any ETA for workers logging in Pages?
  • g
    sadly no, it's actually... a lot harder than you might think so there's a few other things we'll do first
  • g
  • g
    i recommend adding at least the error handling middleware here
  • g
    Yup. I made one with Toucan (https://github.com/robertcepa/toucan-js) yesterday to pass to Sentry. Took about 10 minutes to set up.
  • p
    I'm planning on using just "_worker" file for now, so not sure if middleware is an option. I've seen that Toucan thing as well and it looks interesting.
  • p
    This is because I'd like to make React SSR app, and functions are mapped to it's path.
12345...392Latest