https://discord.cloudflare.com logo
Join Discord
Powered by
# functions
  • g
    Does jekyll do any hashing or similar on local dev assets?
  • w
    No
  • w
    Not by default
  • w
    There are some plug-ins that will do that but unless you’re using one of those The names don’t change
  • w
    It has caused me some issues in the past
  • i
    The SvelteKit adapter adds a hash to the end of each file (so any redeploys and changes don't cache). So I'm in favor of Cache-Control.
  • g
    Gonna need to think about this a bit. I might put out a wrangler version which includes aggressive headers so people can try that out and let me know if it breaks things for them.
  • i
    I'm looking at Redirects for changing 
    /some-page
    to 
    https://some-page.example.com
    . First, does that even work? The 
    Proxying
    section of the docs says no, but is that because of the splat or the domain change?
  • g
    Proxying ≠ redirects
  • i
    Second, are redirects applied in front of a master 
    _worker.js
    function, or will they be obscured by that?
  • g
    So you can redirect, but not proxy.
  • g
    Just dropping in a 
    _redirects
    file:
    Copy code
    /some-page https://some-page.example.com
    should work just fine.
  • g
    _worker.js happens first, then _headers and _redirects, and then the static assets.
  • i
    Hmm... OK. I'm currently getting my functions 404 page instead of being redirected. Do I have to 
    await next()
    ?
  • g
    > my functions 404 page What is that? 
    /functions/[[fallback]].js
    ?
  • i
    Sorry, should have clarified. I'm using the SvelteKit adapter. So the way it works is that it it builds a map of the static assets at build-time, then matches any requests to that and if any match it sends it to the static file.
  • i
    That might be why it's not working, since it's not technically a static file.
  • i
    I have alternatives if the _redirects won't work. Just thought I'd give it a shot.
  • g
    Ah yeah, that makes sense.
  • g
    The SvelteKit adapter could, instead of first checking its own manifest, try to see if it can get something from 
    env.ASSETS.fetch
    https://github.com/sveltejs/kit/blob/master/packages/adapter-cloudflare/files/worker.js#L10-L12
  • g
    If (!response.ok) do svelte things. Else serve the response
  • i
    Good idea. I'll try adding that to my local copy (I'm using an out-of-tree version so I can customize caching) and if it works well I could submit a PR?
  • g
    @User authored the extension, so he might have thoughts.
  • g
    I've never done Svelte stuff myself, so I'm just guessing really.
  • g
    The asset manifest that they maintain might be really important
  • g
    Only other way to keep support for _redirects would be if they parsed it and kept a list of those routes (either in the asset manifest or elsewhere).
  • g
    But massive pain for them to do that.
  • g
    Never mind!
  • g
  • g
    They're already doing stuff for Netlify's _redirects file.
1...181920...392Latest