I’d love to leverage DO with Worker Sites. What are the chances of this becoming a reality in the future? If not, I might need to migrate away 😓

Oh, you are asking about module support in KV Asset-Handler?

Yes. I have a site using KV asset handler for all HTML assets, but the site is also serving an API and I’d like to switch from using millions of KV requests (as my database) over to DO. Would be a lot faster I believe.

soon™️

What's stopping you from using Durable Objects with Workers Sites?

KV Asset-Handler doesn't yet support modules.

Or not fully, from what I understood.

You are probably very much aware of this, but this comes with absolutely zero guarantees, your milage is very much going to vary, etc disclaimers..

What @User said: https://github.com/cloudflare/kv-asset-handler/pull/200

Hey @lukeed, do you have some time next week to look this over together and figure out a way forward?

Yes, 100%. I’ll send you a calendar link via DM now.

@User i would prefer the core handler is abstracted elsewhere, and then the developer imports a method that is specific to their worker format

That is always my preference too indeed.

Is the issue that the event is propagated throughout the handler?

Another option:

ts
// @cloudflare/kv-asset-handler
export function getAssetFromKV(event: FetchEvent, options?: Options): Promise<Response>;

// @cloudflare/kv-asset-handler/module
export function getAssetFromKV(req: Context, ctx: Context, options?: Options): Promise<Response>;

well, the

FetchEvent

is obliterated in a module worker

and so all existing types/utils/etc are going to be expecting that type-match

For good reasons yes 😂

i disagree tbh, but beside the point

Hehe.. I know 😉

we still very much have a fetchevent, but its API is split up into pieces & littered across two objects. so another option could be:

ts
// hacky TS utility to reassemble a FetchEvent
export function assemble(request: Request, ctx: Context): FetchEvent {
  return { ...ctx, request } as FetchEvent;
}

// ...

export default {
  fetch(req, env, ctx) {
    if (req.url.startsWith('/static')) {
      let event = assemble(req, ctx);
      return getAssetFromKV(event, { ... });
    }
  }
};

The best Australian expression there is is "Yeah Nah".. which is my initial reaction..

But.. uhh.. it is actually a pretty clean solution..

i get it 😆 but it's not wrong

those 2 ctx keys are fetchevent properties

i am 10,000% doing this for my own projects

Hehe... you luddite barbarian 😄

haha im very much not a luddite, hence jumping onto workers so early on

So you just can't let go of the past when it comes to workers? 😉