We are totally focused on getting RC1 out with 5.3...
# luceez
zackster
01/31/2022, 11:58 PMWe are totally focused on getting RC1 out with 5.3.9 at the moment....
PRs without tests are only half done, feel like writing some? you can fork the repo and drop them into a /tests folder and Github Actions will run them for you. https://github.com/lucee/extension-hibernate/blob/5.4/.github/workflows/main.yml#L56
We use H2 for most of the Orm tests (as it's standalone), examples here https://github.com/lucee/Lucee/blob/6.0/test/orm/Hibernate.cfc#L20
a
abram
02/01/2022, 8:03 PMso just drop a test folder with a simple testbox test that just validates turning that setting on doesn’t throw an error? I’m not sure how to validate that it’s not auto generating.
abram
02/01/2022, 8:04 PMIs there a readme or documentation somewhere that explains how to build & test the extension? Sorry, but haven’t done any extension work before.
✅ 1
z
zackster
02/01/2022, 8:28 PMif you fork the repo, and enable github actions, each time you commit it will run automatically for you
zackster
02/01/2022, 8:34 PM@Adam Cameron is a big test advocate and I'm sure he can help out here. plus @mborn loves orm stuff
what we need is a
• a test that ORM works when autogen=false
• the same test that ORM works when autogen=true
• tests which tests that shit does fail when the cached definition is out of sync
• and so on...
basically what the patch claims to handle and anything odd we need to handle
zackster
02/01/2022, 8:37 PMi did a heap of work to make this simple as possible for extensions, previously it was a true total cluster fuck of complexity
zackster
02/01/2022, 8:49 PM2 Views