https://cal.com logo
Join Slack
Powered by
Hi, we have found an issue with round robin meetin...
# teams
r
Hi, we have found an issue with round robin meetings being assigned to team members who are not available: https://github.com/calcom/cal.com/issues/3531
z
Thanks for the report will investigate
b
This is exactly the issue I had.
r
@zomars Any update on this?
z
@Emrysal is currently working on a fix
r
@zomars @Emrysal Let us know when it's released. 🙂
Hi @zomars @Emrysal Is there an update on this?
e
WIP @Rebecca Cotton-Weinhold (Virtual Identity) - very close though (actually almost nailed it until an issue with another fix was found I'm fixing now)
r
@Emrysal is this done and part of the new release? This is really important for us.
e
Heya @Rebecca Cotton-Weinhold (Virtual Identity) a fix should be released now! :)
r
Perfect, thank you! looks good so far! 🎉
@Emrysal @zomars Hi, we just tested this again and discovered, that this bug is not actually fixed for team events with multiple users. I have added more details to the topic: https://github.com/calcom/cal.com/issues/3531 We also found another bug for the same setup, so they might be related: https://github.com/calcom/cal.com/issues/4004 We also saw that in the case of a team event after booking, the response from calcom service contains email of user that was not actually the one with whom the booking was made. We believe this may be tightly linked to the two issues above.
@zomars Will you reopen this issue and look into it? It kind of makes the whole team feature unusable the way it is now.
z
We might need to open another PR since this seems like a new issue. If ti wasn't it wouldn't be solved for the other affected teams. so we might have a new edge case here. Tagging @Emrysal since he may provide more context here.
r
@zomars @Emrysal Can you give us a timeline for that? As I said this is quite critical and makes the teams feature kind of unusable, which we really need for a launch happening soon.
z
I'm afraid all our efforts are currently allocated to the V2 launch dated in two weeks
But I will try to give it some time this week to investigate
r
Thank you! 🙏
@zomars Just checking in if there is any update on this?
z
I'm afraid not yet as we're on v2 launch eve
r
@zomars Any update on this, now that V2 is out?
Without this working the whole team feature is pretty useless, because appointments get booked into wrong people calendars and it ignores the availability of that person.
e
I'll pick this up @Rebecca Cotton-Weinhold (Virtual Identity)
j
I believe the problem is that when an event is booked currently there is only a check whether a particular team member is already booked for the time slot to be booked. What’s missing is the check if the time slot is actually in the team member’s working hours. See here: https://github.com/calcom/cal.com/blob/b347f29d6c83e36144c5025f30abe1465469f536/apps/web/pages/api/book/event.ts#L191 The function 
getUserAvailability
actually returns busy times and working hours. But only the busy times are used when booking an event.
r
Hi @Emrysal, is there an update on this bug? We want to launch next week and cal.com is offering some critical features for us, and this bug is really a problem.
e
I'm currently working on debugging this, my eta for resolution is definitely this week so we should be good for next week.
r
@Emrysal Has this been fixed?
e
I got delayed by a critical DST bug that needed fixing before the DST change - but I've finished the investigation; still working on the fix but I expect to finish it tomorrow.
r
@Emrysal Hi, where you able to finish and deploy the fix?
e
Last week I've had a meeting about the right solution to fix this; but it's exactly like @Jakob Pupke said. Right now the working hours are used that are of the event type and not of the different attendees. The problem with this is that there is currently no way to configure the schedule used from a single user - I'm contemplating to use the default availability but in my testing that's not great (very vague behaviour).
My plan now is to continue experimenting but this is my top priority right now along with a minor fix to the booking listing. It may mean an entirely new feature.
j
Sorry to barge in again. But I think using the user’s default working hours is the way to go. This way you prevent that an event is booked for a user that doesn’t even work during that time. OK later you could release a feature that allows a user to define alternative working hours for a event. But let’s be honest. Most users just have one schedule (working hours).
e
@Jakob Pupke I agree with this feedback - it just needs to be clear somehow that if you switch default that'll change your times in round robin events - that was my main concern that it is very unclear how the availability is determined. May be solved also by improving the troubleshooter.
j
@Emrysal I am not sure if I understand your concern. What you describe is better than not using the user’s working hours at all. If I understand the code here correctly, it also doesn’t use the event type’s working hours. Then again for team events it doesn’t really make sense to me that an event type has working hours at all. Anyway thanks for looking into this.
r
I agree with Jakob here, I think step one should be to just use each users default working hours and take into account their calendars. Being able to use a different availability schedule than the user default can be a separate feature. But having a working solution for the default schedule will make this usable to most people.
e
@Jakob Pupke A team event with working hours makes sense if you know ahead of time that all attendees are going to have the same working hours and the same location. Agreed on all accounts
r
In any case, any update, @Emrysal? 😄
e
Going to try and get a fix in before next release on monday 🙏
r
Hi @Emrysal, where you able to do this? We have been talking about this issue for literal months now, and now we are actually live and it is causing issues left and right, which we cannot fix. You told us a month ago you know how to fix it, it is very frustrating.
@Emrysal Is there any fix in sight for this? Is there anything we can do? This not being fixed is really hurting our product at this point, because we cannot use teams with multiple team members in the round robin setting, because it keeps booking appointments at times, that the person is not available.
e
Yes there's a fix in sight @Rebecca Cotton-Weinhold (Virtual Identity); will update when done, should be soon.
The fix for this issue is currently being validated by the team https://github.com/calcom/cal.com/issues/5331 - open draft PR: https://github.com/calcom/cal.com/pull/5342
Undrafted the PR, should go in soon - may see deployment tomorrow
r
@Emrysal @zomars I tested the fix. While now at least I get an error and cannot book non-available timeslots 🎉, the calendar conflicts are still completely ignored when showing the availability to the booking user: https://github.com/calcom/cal.com/issues/5539 So when booking I now see timeslots where nobody is available.
e
I'll see what's going on here, should be much easier to fix than the earlier one
r
Thank you! 🙏
@Emrysal Any update on this?
Hi @Emrysal @zomars Is there any update on the new open issue related to this: https://github.com/calcom/cal.com/issues/5539
z
I'm afraid not @Rebecca Cotton-Weinhold (Virtual Identity) I'll check on the team on who has. bandwidth to investigate.
r
@zomars @Emrysal I saw there is some more people affected by this on Github. Any movement here?
6 Views
Open in Slack
PreviousNext
Powered by