https://avo.cool logo
Hello, we're looking for help to upgrade Avo 2 ...
# avo-2
s
Hello, we're looking for help to upgrade Avo 2 to Avo 3 at RubyGems.org. I was able to use auto-upgrade tool and few manual changes to get at least app boot and running, but there is still a lot of problems and tests failing. The biggest problem I do see is multiple gems for Avo 3 since RubyGems.org is app with open source code and we have no way to add other than public gems into Gemfile. Is there any suggestion for this? We would like to avoid kind of conditional gem deployment. Currently I see a lot of errors like following one. Are those caused by missing
avo-*
private gem? Is Avo 3 still friendly to open apps as Avo 2 was?
Copy code
AbstractController::ActionNotFound: The action 'index' could not be found for Avo::SearchController
m
Thread automatically created by retro♐ in #740893011994738751
l
Hey @silly-lion-46554. I started a conversation with Sam about that. It’s a bit tricky with open source but I have a few ideas on how to get and use the private repos safely as an open source repo
FYI, the community version of Avo should work properly without any of the paid gems
I know you have customized Avo haevily, so there might be a few things that are failing
s
There was some private API used, that's clearly mistake on our side and should be removed. But what about the missing parts in public gem? Is the search index action one of them?
l
I told Sam about this, one of our main concerns is not to have the paid gems leaked in OSS repos. We’ve had quite a few enounters with bad actors in Avo 2 and we’d like to avoid that
s
Sam has sent me here to continue discussion. 🙂
l
Hahah
s
I'm here just to find out what to do, since Avo 2 currently breaks Rails 7.2 upgrade for us so we have like 3 options: - onboard Avo 3 somehow - leave Avo at all - try to fix Avo 2 with newer deps and buy some time to take a look later
l
The global search feature is paid. I’m not sure why you can still see the global search field (where I presume the error comes from)
Ok. Got it. That makes sense. Thanks for putting it bluntly
How urgent is the 7.2 upgrade?
s
not really
l
I’m trying to asses all scenarios
s
7.2 wasn't even released yet
l
Yeah. Got it
s
I'm happy to check Avo 2 and update on my own.
l
The happy path for us and I guess for you too is to get you on Avo 3, but this requires some work on iur end
Could you give us about two weeks to prepare things on iur end?
s
You have all time you need. We're not in rush for now. I'm just wondering what's the plan here.
I can't imagine any scenario of onboarding private gem to RubyGems.org, but happy to hear any suggestion on this.
l
The result would be that anyone can run bundle install and work on the public side of rubygems and the community side of Avo. If that env has the paid gems token, they will be able to install the paid gems too and work on the whole thing
s
Btw. Avo 2 fails with Rails 7.2, but could be just problem on our side (https://github.com/rubygems/rubygems.org/actions/runs/9324105779/job/25668655586?pr=4753). I need to check properly.
l
We would ship “dummy” versions of the paid gems from our gemserver
And Avo would detect they are dummies and still work under the Community license
But still a bit of research to be done
s
That would be awesome. Sam tried originally to detect if paid gem is loaded using like
Gem.loaded_specs["avo-pro"]
...
We're happy to help and share our RubyGems knowledge, just ping us if needed.
l
Worst case scenario, only the prople with the Avo credentials will be ablt to work within Avo
s
We would like to keep developers able to keep their development luxury, like running full specs for app locally.
And in our case, developer can be anyone, since app is open.
l
I understand
We’ll do our best
s
And no worries, if there is no way to achieve this, we can manage somehow.
If you'll find out this setup causes a lot of troubles for you, just let us know.
l
Yup. Got it! I know what you’re aiming for
I added this RFC. Please review it and let me know what you think about this strategy
cc @alert-monkey-67616 👆
a
l
awesome!
this is amazing news @alert-monkey-67616. how can I help? any roadblocks ahead?
a
Not sure! I need to fix the broken tests, and then make sure my check that we do indeed have pro is working (because not having pro silently disregards the authorization…)
l
hmm, we'd be open to add a safeguard for that
2 Views