We have a system test (using Capybara) for our Avo-backed app that randomly, and infrequently, fails. A little bit of context: we're adding a custom field type for phone numbers that handles formatting (using https://github.com/daddyz/phonelib) to the e164 format before saving them to the DB. The error:

ruby
Error:
PhoneNumberFieldTest#test_editing_a_phone_number_that_is_already_properly_formatted:
ActionView::Template::Error: undefined method `has_opted_for_meal_service' for nil:NilClass
    app/avo/resources/client_resource.rb:292:in `block (4 levels) in <class:ClientResource>'

The line throwing the error is for a tab that is conditionally visible. We do that with this code:

ruby
    tab "Meal" do
      panel do
        with_options visible: ->(resource:) { resource.model.has_opted_for_meal_service } do

Any ideas what might be causing

resource.model

to occasionally be

nil

? And/or how to shore up test setup/teardown/isolation so that it's more consistent?

Thread automatically created by Kyle Adams in #740893011994738751

not sure why that flakes out

Yeah, Avo 2. The gist of the test:

ruby
  test "editing a phone number that is already properly formatted" do
    visit "/resources/clients/#{clients(:jane_smith).id}/edit"

    fill_in("Emergency contact phone number", with: "212-300-4000", fill_options: {clear: :backspace})

    click_on "Save"
    click_on clients(:jane_smith).name

    assert_text "EMERGENCY CONTACT PHONE NUMBER\n+1 212-300-4000", count: 1
  end

yes

LOL, well, all the more motivation to get to a place where we can upgrade to 3.

I know. sorry for the extra work 😛