This message was deleted.
# atlantis-contributors
s
This message was deleted.
👍 1
l
My vote would be no to not preinstall anything that's not needed by atlantis itself
@PePe Amengual points out there are mechanisms for end users to add arbitrary packages
Otherwise it's just one more thing that might be out of date we have to continue to patch
r
Yes you can customize the container. Is that the mechanism?
Does atlantis require bash?
If we want to keep it thin, we may want to remove some cruft too
1
l
in my personal setup we have a lot of things we need to customize so we build our own image
FROM: atlantis
, so I haven't used that mechanism, but I believe @PePe Amengual 🙂
🤔 1
yeah we could potentially trim it down, though it's always harder to remove things since we want to be careful about breaking workflows
Which IMO is another reason not to add arbitrary packages, since that means we have to support them indefinitely, or risk breaking people's setups
r
My thinking was kind of along the lines of github actions where jq, coreutils, and bash are available out of the box
But i can understand if an additional package is too much to maintain albeit small in comparison to bash
l
yeah that's my preference, curious what others think. At the very least it'd be good to have a documented process (even if just a comment in the docker build) that says how we decide what to add and what not to add
👍 1