This message was deleted.
# atlantis-community
s
This message was deleted.
👀 1
r
policy checks are not configurable at the per-repo-level. this would need to be built out as a new feature.
😢 1
a
thanks, looks like I will have to manage two atlantis instances then or do you have any other idea?
r
is the desire to disable policy checks for some repos? or what is the goal?
a
thats the goal, I want to enable policy check on only some of the repositories
r
at a high level, i don't think that would be too difficult of a feature to implement. should just be a matter of adding the relevant flags to repo config and hooking them up to policy check command runner. basically it would be an override for the global enable-policy-checks flag. i'd be happy to look over a PR or provide guidance if you'd like to give it a shot.
a
I could try to implement it, looks like the policy_check step is injected globally here right? I would need to remove this and add this flag per repository/workflow. Am I on the right track?
r
i would leave the global arg. i think you'd want to do something along the lines of https://github.com/runatlantis/atlantis/pull/3379 , but at the repo-level, instead of bringing in a new global param
a
I see, thanks for the suggestion, I'm not actually a professional developer but will give it a shot
hi @ross strickland please take a look when you have some time https://github.com/runatlantis/atlantis/pull/3503
in case anyone want to try I uploaded an image with those changes to my repo, working fine AFAICT but will test more next week https://github.com/users/AndreZiviani/packages/container/atlantis/100295000?tag=v0.24.2-policy-check-3
hey @ross strickland @PePe Amengual sorry to tag you directly again but how can we move on with this improvement? we've been running this for a few weeks without any issue
p
if Ross can take a look at the pr that would be great since he has more updated knowledge in this matter
r
Took a look. The change seems sane to me. I left one small comment about documentation.
👍🏽 1
p
@Andre Ziviani can you fix the conflicts?
a
@PePe Amengual sure!
@ross strickland replied on the PR
had some trouble with some tests that were broken, please review when you can
hey @ross strickland @PePe Amengual can we merge this before another conflict happens? 😅
This message contains interactive elements.
p
I really want @Dylan Page to take a look at this
👍 1
d
Approved and merged
a
thanks! 🎉