I wanted to state publicly that I haven't been reviewing PRs as much as I can, I've had competing work priorities that should be resolved soon and return me to a regular review cadence.

Comments pls? https://github.com/runatlantis/helm-charts/issues/227#issuecomment-1593697125

I’ve been going across some of the issues of the helm-chart repo. If there is anything important to do please let me know.

Approved this one https://github.com/runatlantis/helm-charts/pull/299. Can I have a 2nd look from a maintainer pls?

I will be OOO until next tuesday, I tried to do a pass on some pending PRs (might have missed some), will check up on things when I'm back

Release - v0.24.3 New release published by jamengual What's Changed Other Changes • fix(deps): update module github.com/alicebob/miniredis/v2 to v2.30.3 in go.mod by @renovate in #3469 • fix(deps): update module github.com/hashicorp/hcl/v2 to v2.17.0 in go.mod by @renovate in #3470 • fix(deps): update module github.com/spf13/viper to v1.16.0 in go.mod by @renovate in #3472 • fix(deps): update module github.com/xanzy/go-gitlab to v0.84.0 in go.mod by @renovate in #3479 • feat(stats): pass plan stats to markdown templates by @inkel in #3478 • chore(deps): update dependency open-policy-agent/conftest to v0.43.0 in dockerfile by @renovate in #3482 • fix(deps): update module github.com/go-playground/validator/v10 to v10.14.1 in go.mod by @renovate in #3485 • build(deps): bump vite from 4.0.4 to 4.0.5 by @dependabot in #3490 • fix: Check for upstream changes to merge only when planning by @finnag in #3493 • chore(deps): update golang docker tag to v1.20.5 in testing/dockerfile by @renovate in #3494 • fix(deps): update module github.com/google/go-github/v52 to v53 in go.mod by @renovate in #3495 • chore(deps): update dependency open-policy-agent/conftest to v0.43.1 in dockerfile by @renovate in #3496 • chore(deps): bump tally to v4 by @nitrocode in #3498 • feat: Add Terraform command duration to log messages by @inkel in #3484 • chore: Replace go-bindata-assetfs with embed Package by @X-Guardian in #3504 • feat: Add Search Bar to Xterm Output on Job Details Web Page by @X-Guardian in #3507 • fix: Remove the 'Plan Discarded' Message from the Enable/Disable Apply Commands by @X-Guardian in #3511 • feat: Update Lock Index Page to Use a CSS Grid Layout by @X-Guardian in #3509 • fix(deps): update module github.com/xanzy/go-gitlab to v0.85.0 in go.mod by @renovate in #3512 • chore(deps): update dependency hashicorp/terraform to v1.5.0 in .circleci/config.yml by @renovate in #3514 • fix(deps): update module github.com/google/go-github/v53 to v53.1.0 in go.mod by @renovate in #3516 • chore(deps): bump pegomock v3.0.1 by @nitrocode in #3515 • fix(deps): update module github.com/bradleyfalzon/ghinstallation/v2 to v2.5.0 in go.mod by @renovate in #3519 • fix(deps): update module golang.org/x/term to v0.9.0 in go.mod by @renovate in #3520 • fix(deps): update module golang.org/x/text to v0.10.0 in go.mod by @renovate in #3523 • chore(deps): update debian docker tag to v12 in dockerfile by @renovate in #3524 • fix(deps): update github.com/hashicorp/terraform-config-inspect digest to f32df32 in go.mod by @renovate in #3529 • chore(deps): update alpine docker tag to v3.18.2 in dockerfile by @renovate in #3530 • chore(Dockerfile): re-add terraform 1.4 by @nitrocode in #3521 • fix(deps): update module github.com/google/go-github/v53 to v53.2.0 in go.mod by @renovate in #3537 • chore: function docs, linting errors by @pkaramol in #3380 • chore: using constants for checkout strategies by @pkaramol in #3384 • fix(build): use the correct env var to mount pwd by @shouichi in #3491 • fix: parse custom run step output in policy_check by @pseudomorph in #3502 • chore(deps): update dependency @vuepress/plugin-docsearch to v2.0.0-beta.50-pre.1 in package.json by @renovate in #3532 • fix: debian version pinning by @mightyguava in #3528 • fix(deps): update module github.com/petergtz/pegomock/v3 to v4 by @krrrr38 in #3534 • revert(deps): update dependency @vuepress/plugin-docsearch to v2.0.0-beta.50-pre.1 in package.json by @GenPage in #3539 New Contributors • @kevin-fitlg made their first contribution in #3506 • @mightyguava made their first contribution in #3528 • @tszym made their first contribution in #3527 Full Changelog: v0.24.2...v0.24.3 runatlantis/atlantis

hey all, i’ve got a PR that’s been open for a bit and i was wondering how i might get it prioritized for review?

Hi all, I have an issue re-generating the PegoMock files since the repo was updated to use PegoMock v4. For example, if I run

go generate server/core/runtime/pre_workflow_hook_runner.go

I get the following error:

panic: loading input failed: Did not find interface name "PostWorkflowHookRunner"

If I change the

//go:generate

line in the the file from:

//go:generate pegomock generate --package mocks -o mocks/mock_pre_workflows_hook_runner.go PreWorkflowHookRunner

to

//go:generate pegomock generate <http://github.com/runatlantis/atlantis/server/core/runtime|github.com/runatlantis/atlantis/server/core/runtime> --package mocks -o mocks/mock_pre_workflows_hook_runner.go PreWorkflowHookRunner

the mock file is generated successfully. Can somebody check to see if they get the same issue on the

main

branch?

I will check later today

Any chance a maintainer can bump the version on this? https://github.com/runatlantis/helm-charts/pull/297

Looks like the merge of https://github.com/runatlantis/atlantis/pull/3503 is now causing the unit tests check to fail on the main branch.

Hi @Dylan Page, thanks for approving and merging some of my PRs. There are two of mine left open if you fancy taking a look at them: • https://github.com/runatlantis/atlantis/pull/3571 • https://github.com/runatlantis/atlantis/pull/3451

Not a problem, I’ll take another look tonight

@ross strickland thread here for failing tests on main after merging global repo params: https://github.com/runatlantis/atlantis/pull/3379 I think its an obsecure change with the global with some test conditions instead of the actual test that is failing

TestRunAutoplanCommandWithError_DeletePlans

Release - v0.24.4 New release published by GenPage What's Changed Other Changes • chore(deps): update node.js to v18.16.1 in .node-version by @renovate in #3544 • chore(deps): update dependency hashicorp/terraform to v1.5.1 in .circleci/config.yml by @renovate in #3543 • feat: Update the Lock Detail Web Page to Use a Modern Grid Layout by @X-Guardian in #3552 • fix(deps): update module github.com/xanzy/go-gitlab to v0.86.0 in go.mod by @renovate in #3546 • chore(deps): update dependency hashicorp/terraform to v1.5.2 in .circleci/config.yml by @renovate in #3561 • fix(deps): update module github.com/alicebob/miniredis/v2 to v2.30.4 in go.mod by @renovate in #3562 • fix(deps): update github.com/shurcool/githubv4 digest to 599ae7b in go.mod by @renovate in #3575 • fix: Gitlab Autoplan wont trigger when switching Draft to Ready by @X-Guardian in #3568 • fix(deps): update module golang.org/x/text to v0.11.0 in go.mod by @renovate in #3576 • fix: Atlantis Web Console Windows with more than a Screen of Output have a Double Scrollbar by @X-Guardian in #3574 • fix: Atlantis Triggers AutoPlans on Non-Code Change GitLab Merge Event Webhooks by @X-Guardian in #3567 • fix(deps): update module golang.org/x/term to v0.10.0 in go.mod by @renovate in #3580 • fix: Tests broken by #3503 by @AndreZiviani in #3583 • fix: Erroneous Re-display of 'Plan Discarded' UI message by @X-Guardian in #3550 • fix: Discarding a Plan Causes the Whole Working Directory to be Deleted by @X-Guardian in #3553 • chore(deps): update dependency open-policy-agent/conftest to v0.44.1 in dockerfile by @renovate in #3587 • chore(deps): update dependency open-policy-agent/conftest to v0.44.1 in testing/dockerfile by @renovate in #3588 • fix: broken automerge logic by @pseudomorph in #3591 • fix(deps): update module github.com/hashicorp/golang-lru/v2 to v2.0.4 in go.mod by @renovate in #3586 • chore(deps): update dependency @vuepress/plugin-docsearch to v2.0.0-beta.66 in package.json by @renovate in #3593 • chore(deps): update golang docker tag to v1.20.6 in testing/dockerfile by @renovate in #3594 New Contributors • @Almenon made their first contribution in #3402 Full Changelog: v0.24.3...v0.24.4 runatlantis/atlantis

👋 I believe that the tests might be failing on main: https://github.com/runatlantis/atlantis/pull/3603

Hello! Can I get some opinions on this https://github.com/runatlantis/helm-charts/pull/310 please? 🙏

I cleaned up the ADR for project locks/git clones: https://github.com/runatlantis/atlantis/pull/3345 feedback is appreciated

Release - v0.25.0 New release published by chenrui333 What's Changed Other Changes • chore(deps): update vuepress monorepo to v2.0.0-beta.66 in package.json by @renovate in #3600 • feat: Add username to main lock screen by @tobaker in #3597 • chore(deps): update dependency hashicorp/terraform to v1.5.3 in .circleci/config.yml by @renovate in #3599 • chore(deps): update dependency node to v18.17.0 in .node-version by @renovate in #3614 • fix(deps): update module github.com/bradleyfalzon/ghinstallation/v2 to v2.6.0 in go.mod by @renovate in #3602 • fix: alpine package versions bump by @GenPage in #3622 • fix(deps): update module github.com/cactus/go-statsd-client/v5 to v5.1.0 in go.mod by @renovate in #3615 • fix(deps): update module github.com/xanzy/go-gitlab to v0.88.0 in go.mod by @renovate in #3616 • fix(deps): update module github.com/microcosm-cc/bluemonday to v1.0.25 in go.mod by @renovate in #3613 • chore(deps): update dependency hashicorp/terraform to v1.5.4 in .circleci/config.yml by @renovate in #3628 • fix: Update Conftest 'Failed to get default conftest version' Log entry to Info by @X-Guardian in #3632 • chore(deps): update debian docker tag to v12.1 in dockerfile by @renovate in #3630 • chore(deps): update dependency git-lfs/git-lfs to v3.4.0 in dockerfile by @renovate in #3635 • fix: Update the Simple Logger Log Function to log the Correct Caller by @X-Guardian in #3631 • fix: Include information about imports in PlanSuccessStats by @william-richard in #3621 • fix(deps): update module github.com/xanzy/go-gitlab to v0.89.0 in go.mod by @renovate in #3640 • chore: Update server/events/working_dir Logging Configuration by @X-Guardian in #3636 • fix(github): Allow status check/command requirements to work on fork PRs by @ttretau in #3620 • chore(deps): update golang docker tag to v1.20.7 in testing/dockerfile by @renovate in #3642 • fix(deps): update module go.uber.org/zap to v1.25.0 in go.mod by @renovate in #3643 • feat: set

atlantis/apply

check to

successful

if all plans are

No Changes

by @chroju in #3378 • fix(gitlab): Prevent nil pointer dereference when HeadPipeline is empty by @marceloboeira in #3428 • chore: Fix Go Static Check Errors by @X-Guardian in #3637 • chore(deps): lock file maintenance in server/events/testdata/test-repos/workspace-configured/main.tf by @renovate in #3655 • chore(deps): update alpine docker tag to v3.18.3 in dockerfile by @renovate in #3656 • fix: gitlab client failing test by @ghaiszaher in #3653 • fix(deps): update github.com/hashicorp/terraform-config-inspect digest to f15f31b in go.mod by @renovate in #3658 • fix(deps): update module golang.org/x/term to v0.11.0 in go.mod by @renovate in #3650 • fix(deps): update module github.com/go-playground/validator/v10 to v10.15.0 in go.mod by @renovate in #3654 • fix(deps): update module github.com/xanzy/go-gitlab to v0.90.0 in go.mod by @renovate in #3647 • fix(deps): update module golang.org/x/text to v0.12.0 in go.mod by @renovate in #3652 • fix(deps): update module github.com/hashicorp/golang-lru/v2 to v2.0.5 in go.mod by @renovate in #3659 • chore(deps): update dependency hashicorp/terraform to v1.5.5 in .circleci/config.yml by @renovate in #3660 • chore(deps): update dependency node to v18.17.1 in .node-version by @renovate in #3661 • chore: update to use go1.21 by @chenrui333 in #3657 • fix(deps): update module github.com/alicebob/miniredis/v2 to v2.30.5 in go.mod by @renovate in #3662 New Contributors • @tobaker made their first contribution in #3597 • @william-richard made their first contribution in #3621 • @ttretau made their first contribution in #3620 • @ghaiszaher made their first contribution in #3653 Full Changelog: v0.24.4...v0.25.0 runatlantis/atlantis

added an integration to this channel: incoming-webhook

Would it be a nice idea to perhaps feature some 'users' (companies) on runatlantis.io? There's quite a few large companies that use Atlantis and are open about it.

Hi all, I think tests PR tests are failing, again caused by an update from renovate. I put up a PR to revert the change, unless people think it's better to "roll forward": https://github.com/runatlantis/atlantis/pull/3748

Hello all, I am working on a PR to address this policy check issue by introducing a flag for custom policy tools that don't yield JSON output. I'd appreciate some input on the right place to add this type of option. The change in behavior would simply skip the JSON object instantiation here in `project_command_runner.go`, but I only see ProjectContext in scope at that point. I could add the flag to project_context.go, where I believe it would need to be set on every project entry within

atlantis.yaml

. Ideally though, I think it would make more sense as a server flag since it would be common to re-use the same policy checking tool across many projects -- but I can't figure out how it would then be passed to this method in

project_command_runner.go

.

<!here> can anyone review the helm-chart PRs ( all of them) and see if they are still relevant? I do not work on k8 environments so I have no much input on them

Sorry, I've been falling behind on PR reviews, I've been working extra hours at work due to some of my team being on sabbatical + prepping for a move later this month. Feel free to gently remind/ping me

This message was deleted.

I think PR tests may all be failing this module version check:

--- FAIL: TestDefaultProjectCommandBuilder_TerraformVersion (1.17s)

terraform_client_test.go:482: [1.3.9 != 1.3.10]

exp: 1.3.9******

got: 1.3.10

Running

make test

from main fails this test as well

Hello, could I please get a review on this custom policy check PR when time allows?

I'm not sure of the usual cadence/process here, but is there a way I could request a point release now that https://github.com/runatlantis/atlantis/pull/3747 is merged so that 0.25.X is usable for gitlab again?

I'm doing a sweep through all PRs today and planning on a minor release