I see that pinot-spi’s pom has a dependency on log4j-slf4j-impl. I don’t think this is right - it should only depend on slf4j-api. Because of this dependency, the pinot-java-client’s dependency on pinot-spi pulls in the logging implementation, which is not what you want because it means an external project using the client often needs to exclude those logging jars.

Agree...

OK, files https://github.com/apache/incubator-pinot/issues/6364

Thanks... should we do this in two phases? First make the dependency provided and then remove it?

I think for pinot-spi we can just change the dependency to be on slf4j-api. Everyone who uses pinot-spi should have their own logging implementation.

Okay... that’s simple