I’m working on <https://github.com/apache/incubato...
# pinot-devk
Ken Krugler
12/22/2020, 9:30 PMI’m working on https://github.com/apache/incubator-pinot/issues/6293, and had some questions about what the final jar should contain. The pinot-integration-tests-0.7.0-SNAPSHOT.jar is empty, and the pinot-integration-tests-0.7.0-SNAPSHOT-tests.jar has both the code that would be useful for 3rd party projects wanting to test against Pinot (BaseClusterIntegrationTest and associated classes) AND all of the integration test code and resources used by Pinot internally. I’m wondering if it makes sense to try to include only the externally useful code in the -tests jar, or move that code into
src/main/javaKen Krugler
12/22/2020, 9:33 PMI’m leaning towards the first option, as being more consistent (put the externally useful code in the tests.jar file), even though (a) the name is somewhat confusing (blah-tests-version-tests.jar) and (b) it’s more fragile, as I’ll need to select specific packages from the src/test/java directory to include.
Ken Krugler
12/22/2020, 9:38 PMThough this makes it much harder to build a shaded jar with just the dependencies needed for the externally useful code.