hi <@U02DXKP9B6C>, <@UK6JD1E85> thanks for reviewi...
# pinot-devd
Dan DC
04/06/2022, 10:24 AMhi @User, @User thanks for reviewing this PR https://github.com/apache/pinot/pull/7358 I've now rebased it and moved the converters to the schema utils class. I've left a comment with regards regards to config that I thought it'd be easier to discuss over slack
Dan DC
04/06/2022, 10:26 AMthe conversions should be enabled on demand to avoid existing ingestions so I need to pass a config prop down to the record reader. I was wondering if anyone is working on this feature at the moment
Dan DC
04/06/2022, 10:27 AMI was also wondering how the test data for these classes was generated so I can top up
r
Rong R
04/06/2022, 4:15 PMlooks good to me. i think you can create a AvroRecordExtractorConfig in the same PR.
d
Dan DC
04/06/2022, 6:42 PMI've done this now but I can't figure out how this class is created for a realtime table
👍 1
Dan DC
04/06/2022, 6:44 PMFor what I've seen it doesn't seem like this is possible at the moment, I may need to do some refactoring
r
Rong R
04/06/2022, 8:02 PMi am not sure i understood the issue that would require a refactoring. would you mind commenting on the PR so we can take a look please?