Hello, I am working on a PR for issue #12266 and I...
# pinot-dev
b
Hello, I am working on a PR for issue #12266 and I running into some issues with the tests and was hoping I could get some help and or direction on what I am doing wrong. 1. When I run mvn clean install -Pbin-dist to run all test locally, the testZookeeperDataEndpoints test always fails on test case 3, with the error "ZookeeperResourceTest.testZookeeperDataEndpoints:108 » NoHttpResponse localhost:((insert Random port number)) failed to respond", however when I run this test by itself through Intellij, it passes every time. 2. How do you set the port the query console will reside on? When I spin up my cluster using the Quickstart method, the query console gets placed on port 9000 along with the controller. This causes the testDriver test in the PinotDriverTest class to fail as it tries to connect using this URL: jdbc:pinot://localhost:8000?controller=localhost:9000, if I change it to be jdbc:pinot://localhost:9000?controller=localhost:9000 the test will pass as that is the URL to my cluster. The errors I get through running the test seem to come down to configuration issues, and are testing parts of the code my changes do not touch (my changes are small). Is there a protocol to setting up a Pinot Cluster so all the tests are at least immune to failing based on if your controller is connect to the right port or not? Thank you in advance for any help you can provide.
Just following up to see if anyone can provide me some guidance. I ran through all the tests and they all come down to what I described above where they fail when running the mvn command but pass if ran in the IDE, or its a compilation or dependency error. I have only updated the jdbc client and that test passes, the failures come from spots I haven't touched. Am I ok to move forward with a PR or do I need to get the tests figured out?
g
Sounds quite strange that the test fails in mvn but not in intellij. The other way around is the most common. Our tests are running correctly in the CI, so I guess that is something in your local. Can you try to open the PR? That should trigger the tests in our CI and then we can verify there whether it fails in other environments or not
(I'm sorry, I thought I did respond, but it seems I forgot to press enter and my message was in draft facepalm )
b
No worries! I will go ahead and get the PR submitted. Thank you!
Sorry, I am just now getting around to submitting this PR, and this may be dumb question but this is my first PR for Pinot, how do I tag the PR with a label?
g
AFAIK only committers can add labels. At least I didn't find the way to do it myself! 😄 . Don't worry, they will be added later. You will also need a first approve on the pipeline in order to execute (that won't be needed in further PRs)