Apache Pinot

Hello team, is there any governance around running test coverage report?

I am trying to work on some UTs, and wanted to run code coverage for this PR.
<https://github.com/apache/pinot/pull/12294>

I think drafts are not executed by GHA. Or more specifically, a committer has to manually approve each execution (ie each commit). You may want to remove the draft status in order to be actually executed

I removed draft, however it is still asking for ~review~  workflow approval.

thanks, I will try to update the the PR with all the tests, I am planning for this issue.

Hello Mayank, for issue <https://github.com/apache/pinot/issues/5695>, I picked InstanceAssignmentConfigUtils.java file. I covered all lines, <https://github.com/apache/pinot/blob/f43664dd1384086be6669aa76a3e08c2db8a11e1/pinot-common/src/main/java/org/apache/pinot/common/assignment/InstanceAssignmentConfigUtils.java#L77|except this line>, I checking when the flow could come here. Meanwhile I wanted help with review, whom can I reach out to?

Thanks <@U038ER3FKM2> for the review, I have squashed the commit. Also do we need null checks here?
<https://github.com/apache/pinot/blob/9c1bb02decc32f5e685c69667a87e1bf7621fb2e/pinot-common/src/main/java/org/apache/pinot/common/assignment/InstanceAssignmentConfigUtils.java#L113|https://github.com/apache/pinot/blob/9c1bb02decc32f5e685c69667a87e1bf7621fb2e/pino[…]ache/pinot/common/assignment/InstanceAssignmentConfigUtils.java>

I'm not an expert on the ingestion code, but I would say it would be nice to add a check there. There may be granted that at that point getSegmentPartitionConfig() always returns not null, but it doesn't seem trivial to reason why and a check would be super cheap, so I would think it would be nice to add the check.

Okay, maybe we can go ahead with this PR where it only involves test coverage.
Shall I can open new issue to address null check?

Hey <@U038ER3FKM2> can we go ahead with this PR? I am currently not working on this issue.

Sure! But I cannot help here that much. I was recently promoter as committer so I in theory I should be able to approve your PR. But in practice it seems GitHub doesn't recognize me as a committer, so I my approvals are not valid (yet)

I'm going to ping some other committers to see if they can merge your PR