https://pinot.apache.org/ logo
Join SlackCommunities
Powered by
# pinot-dev
  • k

    Kishore G

    06/05/2020, 2:31 AM
    Can we reproduce this?
  • m

    Mayank

    06/05/2020, 2:32 AM
    Yes intermittently
  • m

    Mayank

    06/05/2020, 2:32 AM
    On local mac
  • k

    Kishore G

    06/05/2020, 2:33 AM
    From IDE?
  • m

    Mayank

    06/05/2020, 2:38 AM
    No cli
  • m

    Mayank

    06/05/2020, 2:42 AM
    By running travis_quickstart.sh, I was able to reproduce this once in one of my initial runs, and have not been able to repro after that.
  • s

    Subbu Subramaniam

    06/05/2020, 3:33 AM
    the latest travis run seems to have passed
  • m

    Mayank

    06/05/2020, 3:34 AM
    Yes, I saw that
  • m

    Mayank

    06/05/2020, 3:34 AM
    I think we can change the script for it to be less brittle
  • m

    Mayank

    06/05/2020, 3:34 AM
    Copy code
    if [ "${COUNT_STAR_RES}" -gt 0 ]; then
        if [ "${RES_1}" -eq 0 ]; then
          RES_1=${COUNT_STAR_RES}
          continue
        fi
        if [ "${COUNT_STAR_RES}" -gt "${RES_1}" ]; then
          PASS=1
          break
        fi
      fi
  • m

    Mayank

    06/05/2020, 3:34 AM
    We need to protect against case where COUNT_STAR_RES = ''
  • m

    Mayank

    06/05/2020, 3:35 AM
    The above code is run in a loop with sleep 1 anyways, so subsequent call should pass
  • s

    Subbu Subramaniam

    06/05/2020, 3:44 PM
    so, u think it is just the startup time?
  • s

    Subbu Subramaniam

    06/05/2020, 3:45 PM
    If so, then this will work, yes.
  • m

    Mayank

    06/05/2020, 3:45 PM
    That’s what the log says, queries sent before table created, which causes script to fail
  • m

    Mayank

    06/05/2020, 3:45 PM
    PR was merged last night
  • s

    Subbu Subramaniam

    06/05/2020, 3:46 PM
    ok, thx
  • k

    Kishore G

    06/05/2020, 3:48 PM
    was this added recently?
  • m

    Mayank

    06/05/2020, 4:00 PM
    In feb
  • m

    Mayank

    06/05/2020, 4:43 PM
    Do we have native null support enabled now? If so, where can I find the documentation?
  • k

    Kishore G

    06/05/2020, 4:44 PM
    no, we just have support for creating null vector
  • k

    Kishore G

    06/05/2020, 4:44 PM
    we dont use it in execution yet
  • m

    Mayank

    06/05/2020, 4:45 PM
    Ok
  • k

    Kishore G

    06/05/2020, 4:45 PM
    is someone asking for it?
  • m

    Mayank

    06/05/2020, 4:45 PM
    There was a question around default null value choices, and it reminded me of the null vector PR, so was asking for status.
  • k

    Kishore G

    06/05/2020, 4:46 PM
    that PR is merged
  • k

    Kishore G

    06/05/2020, 4:47 PM
    we need to handle the x != NULL in filter (this is easy)
  • k

    Kishore G

    06/05/2020, 4:47 PM
    but sum(x) is harder
  • m

    Mayank

    06/05/2020, 4:48 PM
    Ok
  • h

    Haibo Wang

    06/08/2020, 6:15 PM
    Another reminder on validating release-0.4.0-RC2
1...131415...30Latest