https://pinot.apache.org/ logo
Join Slack
Powered by
# general
  • m
    I created that ask for some to support aliases for something I was working on.
  • m
    We do have an internal ticket for it, will bring it up to see if/when it can be supported.
    🙌 1
  • m
    Would help if you could +1 on the issue, and how you plan to use it.
    👍 1
  • k
    Alias support is needed for superset rt?
  • a
    Yes that is correct
  • s
    https://github.com/apache/incubator-pinot/pull/3705 adds LinkedIn codestyle guide to the repo. We might soon enforce this by enabling the build time checkstyle task - does anyone have concerns with it?
  • k
    Is this checking for format?
  • k
    Or coding conventions as well
  • s
    we haven't enabled it, but plan to fail the build if the format is not adhered to
  • k
    So only code format?
  • s
    I think it has rules basic coding conventions
  • k
    Which one did we use?
  • k
    google? Linkedin?
  • s
    LinkedIn
  • k
    Cool. Last time we tried this, we could not get it to work with eclipse and idea
  • s
    Jackie added formats for both eclipse and intellij; I haven't tried eclipse though
  • k
    We took a file and eclipse and idea would format it differently
  • m
    I am not sure if this has been tried on eclipse?
  • k
    I tried this few years back and gave up
  • m
    Yes, last time even within Idea, different versions behaved differently
  • m
    Especially for default values not specified in the file
  • k
    I would love to have this enforced if we can get it to work.
  • s
    @User - how did you generate the eclipse and intellij files?
  • k
    also, does this catch complex one line code?
  • k
    deserialize(clazz, io.vavr.collection.HashSet.ofAll(config.entrySet()) .toMap(entry -> Tuple.of(entry.getKey(), entry.getValue().unwrapped())), "");
  • k
    first of all this does not compile for me in eclipse
  • s
    I doubt it will catch it
  • k
    and second, its very taxing for to understand
  • k
    for me*
  • s
    the quick overview of rules the other day seemed to be more focused on formatting; but I haven't run the checkstyle myself to see what exactly it catches
1...646566...160Latest