https://pinot.apache.org/ logo
Join Slack
Powered by
# general
  • m

    Mayank

    05/11/2020, 4:23 PM
    Do you have equality predicated on partition key?
  • s

    Shounak Kulkarni

    05/11/2020, 4:25 PM
    not doing partition on key currently. only simple partition on kafka topic
  • s

    Shounak Kulkarni

    05/11/2020, 4:26 PM
    can you share link to replica group implementation on realtime tables?
  • m

    Mayank

    05/11/2020, 4:29 PM
    Ok could you elaborate why you think your query should not go to all servers?
  • s

    Shounak Kulkarni

    05/11/2020, 4:31 PM
    actually its giving high latency on broker compared to less servers/replicas
  • s

    srisudha

    05/11/2020, 4:34 PM
    And @User clearly we see that server is responding with 1to 5 ms but broker is taking time to respond..
  • s

    srisudha

    05/11/2020, 4:34 PM
    Is there any other solution?
  • m

    Mayank

    05/11/2020, 4:34 PM
    ReplicA group and partitioning will help
  • k

    Kishore G

    05/11/2020, 4:34 PM
    is there a sample response and lets move to #C011C9JHN7R
  • s

    srisudha

    05/11/2020, 4:36 PM
    Sure we will post all details there..
  • e

    Elon

    05/11/2020, 4:45 PM
    Hi, we found an issue where non-pql queries that have grouping columns in the select list which are not included in the group by clause are just ignored instead of throwing a syntax error. Example:
    Copy code
    select foo, count(*), max(bar) from table
  • e

    Elon

    05/11/2020, 4:45 PM
    This query will return results as if it was written:
    Copy code
    select count(*), max(bar) from table
  • e

    Elon

    05/11/2020, 4:45 PM
    i.e. the grouping column is ignored
  • k

    Kishore G

    05/11/2020, 4:52 PM
    @User looks like calcite does not support that syntax and requires explicit group by
  • e

    Elon

    05/11/2020, 4:53 PM
    It doesn't seem to throw an error though, just ignores the group by column. This can be verified in the pinot controller ui.
  • e

    Elon

    05/11/2020, 4:54 PM
    I am using pinot-3.0, i.e. the last commit where the version is
    0.3.0-SNAPSHOT
  • s

    Sidd

    05/11/2020, 4:55 PM
    yes, standard SQL compliant behavior is to have the group by column explicitly in the select list
  • s

    Sidd

    05/11/2020, 4:55 PM
    Otherwise it won't be projected in the result set
  • s

    Sidd

    05/11/2020, 4:57 PM
    note that group by is still done correctly -- it's just that column won't be part of result columns projected
  • k

    Kishore G

    05/11/2020, 4:57 PM
    @User lets create an issue, we should be able to support the short hand
    👍 1
  • k

    Kishore G

    05/11/2020, 4:57 PM
    @User this is a different case rt, there is no group by clause in the query
  • e

    Elon

    05/11/2020, 5:00 PM
    https://github.com/apache/incubator-pinot/issues/5361
  • s

    Sidd

    05/11/2020, 5:01 PM
    @User why are we calling it a grouping column when there is no group by in the query?
  • k

    Kishore G

    05/11/2020, 5:01 PM
    presto supports that syntax, i have seen shasta also supports that
  • k

    Kishore G

    05/11/2020, 5:01 PM
    its a shorthand 🙂
  • e

    Elon

    05/11/2020, 5:02 PM
    grouping column - i.e. if the user inadvertently forgot to include a group by. Presto would return an error, more of a question. What's shasta?
  • k

    Kishore G

    05/11/2020, 5:03 PM
    https://static.googleusercontent.com/media/research.google.com/en//pubs/archive/45394.pdf
    👍 2
  • k

    Kishore G

    05/11/2020, 5:03 PM
    yeah, we should return an error for now
  • s

    Sidd

    05/11/2020, 5:04 PM
    yes it should be a syntax error
  • e

    Elon

    05/11/2020, 5:04 PM
    Yep, just verified using presto's tpch connector:
    Copy code
    presto:tiny> select name, count(*) from nation;
    Query 20200511_170334_11208_ru3kx failed: line 1:8: 'name' must be an aggregate expression or appear in GROUP BY clause
    io.prestosql.spi.PrestoException: line 1:8: 'name' must be an aggregate expression or appear in GROUP BY clause
1...132133134...160Latest