https://linen.dev logo
#connector-development
Title
# connector-development
m

Mahdi Dibaiee

04/07/2022, 2:26 PM
Hello 👋 I’ve hit a bug with
source-facebook-marketing
where it assumes
user_tos_accepted
to be a number but it’s actually an object, and so read operations fail. I’ve opened an issue and a PR where I’m reusing the schema definition of
tos_accepted
for
user_tos_accepted
which makes both nullable objects. Can I get a review from one of the maintainers please? It’s a small PR but blocks our use of this connector. thanku Issue: 11800 PR: 11801
Follow-up question for this: The current schema has
web_custom_audience_tos
as a property of
tos_accepted
, however as far as I understand, the fields of
tos_accepted
are dependent on the custom audience definitions of the account, so they can be anything. Do we even need to define
web_custom_audience_tos
in these objects? Might it not be better to leave it empty?
Another question: is it possible to make an airbyte connector use a different schema (when using it from Docker) while I wait for such PRs to go through?
s

Sherif Nada

04/07/2022, 2:44 PM
Did this change with a recent version? Which connector version are you using mahdi?
m

Mahdi Dibaiee

04/07/2022, 2:48 PM
I’m using the latest connector image, so
0.2.24
I don’t think this has changed with a recent version, but it doesn’t seem to be compatible with Facebook’s API in any case at the moment, see the issue where I have linked the Facebook API example
Also found this just now, Facebook Business SDK itself defines that field as `map<string, int>`: https://github.com/facebook/facebook-python-business-sdk/blob/main/facebook_business/adobjects/adaccount.py#L3964
2 Views