Channels
c
charles
10/21/2020, 5:34 PM
is anyone active working on reorging the airbyte-integrations dir structure?
u
user
10/21/2020, 5:34 PMmichel has a PR for it
u
user
10/21/2020, 5:35 PMyeah. honestly probably easier to start from scratch.
u
user
10/21/2020, 5:35 PMif not i’m going to go ahead and do it following jared’s structure https://github.com/airbytehq/airbyte/pull/626#pullrequestreview-512165494
u
user
10/21/2020, 5:35 PMdoes it have a ton of merge conflicts or something?
u
user
10/21/2020, 5:35 PMyes
u
user
10/21/2020, 5:35 PMissue is that maybe that structure is not very python friendly though
u
user
10/21/2020, 5:36 PMfair enough. what would make the structure python friendly?
u
user
10/21/2020, 5:37 PMi've been trying to make one but haven't succeeded yet
u
user
10/21/2020, 5:38 PMwhat is the concern with even the current structure from a python perspective? Is it within the individual package dirs? or the monorepo as a whole?
u
user
10/21/2020, 5:39 PMi think it’s important to get out of current state which is pretty non sensical.
u
user
10/21/2020, 5:40 PMyeah I think from a project organization perspective there are better options than what we have
u
user
10/21/2020, 5:40 PMI'm just trying to understand what makes a project structure good or bad for multiple python libraries and apps
u
user
10/21/2020, 5:41 PMpython is not usually used in monorepo i think
u
user
10/21/2020, 5:41 PMbut it should still be doable
u
user
10/21/2020, 5:42 PMoutside of that are there constraints?
2 Views