https://linen.dev logo
m

Murilo Nigris

01/20/2021, 11:41 AM
Hi Airbyte team! I'm working on the appsflyer connector, and I've 2 issues: 1. The tap-appsflyer defines in the setup.py the usage of pip package 'attrs==16.3.0', however pytest requires the 'attrs>=17'. When i run the gradlew integrationTest it fails. My solution was to force the usage of the 'attrs==19.1.0' in the Airbyte setup.py:
Copy code
install_requires=["airbyte-protocol", "tap-appsflyer==0.0.12", "requests", "attrs==19.1.0"]
Is this solution ok? Otherwise I would have to submit a PR for singer and it usually takes some time, and I would rather not do it for now. 2. When I run the cmd below in the source-appsflyer-singer directory with venv activated, I get the error in the print, event though the appsflyer request succeeds.
Copy code
python main_dev.py discover --config secrets/config.json
I've commited my changes in this branch
u

user

01/20/2021, 3:52 PM
1. if pinning the version works when you test it, then yeah, it's okay!
u

user

01/20/2021, 3:55 PM
2. i've never seen this before, but it looks like this SO answer might be related. https://stackoverflow.com/a/21058946/4195169
u

user

01/20/2021, 3:55 PM
is it possible that the singer tap is outputting multiple objects during discover? don't know if you can get a print statement in there to verify.
u

user

01/20/2021, 3:56 PM
if so, we may need to add a shim in the base-singer code to handle that case.
u

user

01/20/2021, 5:34 PM
Thanks Charles! I'll take a look later today 🙂
u

user

01/26/2021, 3:11 AM
Hey Charles! I decided to re-do the singer appsflyer integration using their new format. The current integration doesn't have the 'discover' method, maybe that's the reason for the error. (I'm working on a few other activities, so I won't go back to this issue until tomorrow)
u

user

01/26/2021, 3:19 AM
The current integration doesn't have the 'discover' method,
as in the singer version doesn't have a discover method? good to know!
u

user

01/26/2021, 3:20 AM
we re did the docs for building a python source. you can find them here https://docs.airbyte.io/tutorials/building-a-python-source. hopefully they make it easier! lmk if you have any questions.
3 Views