charles
user
01/20/2021, 10:21 PMuser
01/20/2021, 10:21 PMuser
01/20/2021, 10:21 PMuser
01/20/2021, 10:21 PM"username": {
"description": "Username to use to access the database.",
"type": "string",
"order": 1
},
"password": {
"description": "Password associated with the username.",
"type": "string",
"airbyte_secret": true,
"order": 2
},
user
01/20/2021, 10:21 PMuser
01/20/2021, 10:22 PMuser
01/20/2021, 10:22 PMuser
01/20/2021, 10:23 PMuser
01/20/2021, 10:24 PMuser
01/20/2021, 10:24 PMuser
01/20/2021, 10:24 PMuser
01/20/2021, 10:24 PM{
"documentationUrl": "<https://docs.airbyte.io/integrations/destinations/postgres>",
"supportsIncremental": true,
"order": ["username", "password"],
"properties": { ...
user
01/20/2021, 10:25 PMuser
01/20/2021, 10:27 PMuser
01/20/2021, 10:28 PMuser
01/20/2021, 10:28 PMoneOf
suser
01/20/2021, 10:29 PMuser
01/20/2021, 10:29 PMuser
01/20/2021, 10:31 PMuser
01/20/2021, 10:37 PMuser
01/20/2021, 10:54 PMI don't think that's true
@Jared Rhizor (Airbyte) Actually I believe thats how it is working now. Postgres doesn’t have title - so names are in lowercase. But the thing is, that initially we had some titles in locales configured, so that’s why you can see some names.
"form.password": "Password",
"form.dbname": "DB Name",
"form.postgres_host": "Host",
"form.postgres_port": "Port",
"form.postgres_username": "User",
"form.postgres_password": "Password",
"form.postgres_database": "DB Name",
"form.postgres_schema": "Schema",
Since that time our approach changed to the better one and probably you see here some mix of old concept and new one. We can actually better just remove those locales to keep it more clear
const defaultLabel = formatMessage({
id: `form.${fieldKey}`,
defaultMessage: fieldKey
});
const label = `${property.title || defaultLabel}${
property.isRequired ? " *" : ""
}`;
user
01/20/2021, 10:55 PMuser
01/20/2021, 10:55 PMuser
01/20/2021, 10:55 PMuser
01/20/2021, 10:57 PMso it isn't in the spec, it's in the frontend
Well actually its more about the spec. If I remove those locales - our names will be in lower case and may even have a bit ugly naming ( before that we had postgres_database
, but I may be mistaken.user
01/20/2021, 11:00 PMuser
01/20/2021, 11:25 PMjdbc_url
, destination_path
) and for me something like Jdbc_url
looks much uglier in UI than jdbc_url
We may try to make some common flow - like PascalCase all snake_case and overwrite the ones we do not like with titles.user
01/20/2021, 11:29 PMuser
01/20/2021, 11:30 PMpostgres_
prefixesuser
01/20/2021, 11:32 PMuser
01/21/2021, 12:01 AMuser
01/21/2021, 12:02 AMuser
01/21/2021, 12:07 AMuser
01/21/2021, 12:27 AMuser
01/21/2021, 12:27 AM