Folks I have a question about new “advancedAuth” specification is it ok that ? on Java part we have camelCase

oauthUserInputFromConnectorConfigSpecification

https://github.com/airbytehq/airbyte/blob/cb9c5123b1789310ee313c2823868ecba65aa35f/airbyte-api/src/main/openapi/config.yaml#L3259 on Python part we have snake_case

oauth_user_input_from_connector_config_specification

https://github.com/airbytehq/airbyte/blob/cb9c5123b1789310ee313c2823868ecba65aa35f/airbyte-cdk/python/airbyte_cdk/models/airbyte_protocol.py#L122 I see that for old deprecated specification “authSpecification” we have camelCase for both python and java

the java part is for the API server, the bottom is for the airbyte protocol, so the naming convention is appropriate for each

I am trying to add new “advancedAuth” section to

spec.json

do I need to use camelCase or snake_case ?

you can go with the snake_case on the spec.json (protocol side)

@Chris (deprecated profile) hm I just tried both way “camel_case” vs “snakeCase” for

spec.json

1) cat spec.json

"advanced_auth": {
    "auth_flow_type": "oauth2.0",
...

2) cat spec.json

"advancedAuth": {
    "authFlowType": "oauth2.0",

camalCase - OK snake_case - UI generate error: “Fetching connector failed.”

is this working?

"advancedAuth": {
    "auth_flow_type": "oauth2.0",

advancedAuth

camelCase and the rest of properties nested inside snake_case

this works :

"advancedAuth": {
  "auth_flow_type": "oauth2.0",
  "oauthConfigSpecification": {
    "completeOAuthOutputSpecification": {
    "completeOAuthServerInputSpecification": {
    "completeOAuthServerOutputSpecification": {

ah, “rest of snake_case”

let me do 2-nd check…

this also works

"advancedAuth": {
      "auth_flow_type": "oauth2.0",
      "oauth_config_specification": {
        "complete_oauth_output_specification": {
        "complete_oauth_server_input_specification": {
        "complete_oauth_server_output_specification": {

let’s go with that last one then!

ok thank

you can take a look at the unit test here https://github.com/airbytehq/airbyte/blob/master/airbyte-oauth/src/test/java/io/airbyte/oauth/flows/BaseOAuthFlowTest.java and how the object is filled up to know what you need to put in there btw