https://linen.dev logo
Join Slack
Powered by
# dev-frontend
  • c

    Chris (deprecated profile)

    12/22/2020, 10:02 AM
    Hi, Is it normal when I click on the "reset" button of this window, it just adds "Pending" jobs in the background but nothing happens in the UI with that pop-up window? (I didnt notice at first and thought it didnt register my click so I created multiple lines marked at 10:46 and 10:47 before realizing it was actually creating jobs behind the popup) I would have expected it would disappear once i click on it? or is that the intended behaviour?
    a
    • 2
    • 10
  • c

    charles

    12/23/2020, 1:05 AM
    Artem, if we wanted to implement a "skip onboarding" button, your preferred way of doing it would be that we track onboarding_skipped on the backend, right?
    a
    • 2
    • 6
  • c

    charles

    12/26/2020, 2:21 PM
    4th question For this task https://github.com/airbytehq/airbyte/issues/1407 What are you suggestion? How should it look like? We can’t just make it wide enough as it may be a bit buggy and we are not sure what text will be inside. Should we just split text on numerous lines?
    a
    • 2
    • 3
  • c

    charles

    12/26/2020, 2:22 PM
    1st question
    Copy code
    [1:10 AM] job_info: {
      attempts: [...]
      job: {
        id: 126, 
        configType: "check_connection_source", 
        createdAt: 1608847715,
        id: 126,
        status: "succeeded",
        updatedAt: 1608847719
      },
      message: "(401, 'The access token is invalid or has expired')",
      status: "failed",
    }
    for 
    v1/scheduler/sources/check_connection
     and 
    v1/scheduler/destination/check_connection
    I receive  
    status: "failed"
     . But in 
    job_info.job
     we have 
    status: "succeeded"
    a
    • 2
    • 8
  • c

    charles

    12/26/2020, 2:53 PM
    2nd question
    /v1/sources/discover_schema
    received object is
    Copy code
    { 
      schema: {...}, 
      job_info: {
        job: {...},
        attempts: [...]
      }
    }
    could you add 
    status
     field (near schema and job_info) like in 
    check_connection
     request
    a
    • 2
    • 2
  • c

    charles

    12/26/2020, 3:17 PM
    3rd question We have next statuses
    Copy code
    PENDING("pending"),
    
    RUNNING("running"),
    
    INCOMPLETE("incomplete"),
    
    FAILED("failed"),
    
    SUCCEEDED("succeeded"),
    
    CANCELLED("cancelled");
    Right now we assume only Failed as actually Failed and everything else as success. Thats why we display Incomplete as success. Should we add more icons for statuses? Like warning or some in progress icon? So it would be awesome if you can say mapping between status and icon
    a
    • 2
    • 5
  • s

    s

    01/15/2021, 8:36 PM
    I’m getting the following error on a clean build
    Copy code
    :airbyte-integrations:connectors:source-appstore-singer:installLocalReqs
    a
    c
    j
    • 4
    • 47
  • a

    Artem Astapenko

    01/15/2021, 11:54 PM
    Hm not quite sure what I have done but after some building and rebuilding those part is passing now ( I have commented lines above, but forgot to save and everything have been built anyway ) Trying to build one more time.
    c
    • 2
    • 2
  • c

    Chris (deprecated profile)

    01/21/2021, 5:38 PM
    Is it intended that I can’t change the version of the connectors in the UI anymore?
    a
    • 2
    • 19
  • c

    charles

    02/01/2021, 10:20 PM
    @Artem Astapenko We need extend to the API and the FE a data model that can handle that data schemas can be nested. i.e. it's not always just table / columns, but can be nested. I have put up a draft PR to get your feedback on how you would prefer to work with this nested structure on the frontend. Can you take a look at it before our sync tomorrow so we can discuss it then and pick what we should do?
    👌 1
    • 1
    • 1
  • c

    Chris (deprecated profile)

    02/05/2021, 8:57 AM
    Hello, @Artem Astapenko ! This PR is ready for you to take a look as we discussed earlier in the week: https://github.com/airbytehq/airbyte/pull/1934 It will be blocked and won’t be merged to master until your FE changes will be ready! In the meantime, I will continue to finish a few modifications from the code review on top of it
    a
    c
    • 3
    • 3
  • a

    Artem Astapenko

    02/09/2021, 11:07 PM
    Chris, I have next error in api-catalog branch. Have you faced that before?
    Copy code
    > Task :airbyte-integrations:connectors:destination-jdbc:test
    
    JdbcDestinationTest > testSpec() FAILED
        org.testcontainers.containers.ContainerLaunchException: Container startup failed
            at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:330)
            at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:311)
            at io.airbyte.integrations.destination.jdbc.JdbcDestinationTest.setup(JdbcDestinationTest.java:115)
    
            Caused by:
            org.rnorth.ducttape.RetryCountExceededException: Retry limit hit with exception
                at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88)
                at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:323)
                ... 2 more
    
                Caused by:
                org.testcontainers.containers.ContainerLaunchException: Could not create/start container
                    at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:497)
                    at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:325)
                    at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81)
                    ... 3 more
    
                    Caused by:
                    org.testcontainers.containers.ContainerLaunchException: Timed out waiting for log output matching '.*database system is ready to accept connections.*\s'
                        at org.testcontainers.containers.wait.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:49)
                        at org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:35)
                        at org.testcontainers.containers.PostgreSQLContainer.waitUntilContainerStarted(PostgreSQLContainer.java:130)
                        at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:440)
                        ... 5 more
    c
    c
    • 3
    • 7
  • a

    Artem Astapenko

    02/10/2021, 1:02 AM
    @charles could you please give an example of rather complex jsonSchema that is supposed to be used for catalog? Probably with inner fields and etc? Or at least which source can have one. Also I do not see cleanedName and dataType for fields anymore. Thats what we had
    Copy code
    name: string;
    cleanedName: string;
    type: string;
    dataType: string;
    and I only receive now
    type
    and
    name
    . Also just in case I have selected bad source that doesn’t have
    cleanedName
    -
    cleanedName
    was renamed to
    aliasName
    on root level. Should I assume that we can receive such field?
    c
    c
    • 3
    • 33
  • a

    Artem Astapenko

    02/11/2021, 10:00 PM
    @charles @Chris (deprecated profile) looks like some error was introduced
    c
    • 2
    • 3
  • c

    charles

    02/12/2021, 6:07 PM
    this is when hitting "continue" in the initial preferences page.
    a
    • 2
    • 25
  • m

    Maggie Zhang

    02/24/2021, 8:57 AM
    Could Superset sync data to the destination table which I can choose it ?
    ✅ 1
    c
    j
    • 3
    • 8
  • a

    Artem Astapenko

    03/02/2021, 9:13 PM
    Small question: should we bump webapp version in package.json and when should we do it? Should it go along with version increase of the whole project?
    c
    • 2
    • 7
  • a

    Artem Astapenko

    03/03/2021, 12:27 AM
    Just so you know - we finally have e2e test for frontend now as part of CI. Tested few times and they were working fine. So if something will be broken on BE or FE site - we will know asap.
    🙌 2
    j
    • 2
    • 1
  • c

    charles

    03/03/2021, 6:01 PM
    Hi Artem, we had an issue come up that we'd like to add to this week's sprint. It's a high priority which is why I am messaging about it. Obviously it's a little late to add stuff. If we bump some of the lower priority stuff that you're currently assigned, do you think that we could squeeze this issue in this week?
    a
    c
    • 3
    • 19
  • a

    Artem Astapenko

    03/05/2021, 11:39 AM
    Was this task https://github.com/airbytehq/airbyte/issues/2285 just for input or we actually plan to work on other UI changes too?
    c
    • 2
    • 2
  • a

    Artem Astapenko

    03/05/2021, 3:53 PM
    @charles According to the task https://github.com/airbytehq/airbyte/issues/1960 It says:
    Copy code
    green = active and last sync was successful
    grey = not active
    red = active and last sync failed
    but we have only next :
    Copy code
    ConnectionStatus:
          type: string
          description: Active means that data is flowing through the connection. Inactive means it is not. Deprecated means the connection is off and cannot be re-activated. the schema field describes the elements of the schema that will be synced.
          enum:
            - active
            - inactive
            - deprecated
    How should we understand that last_sync was failed? Will we have 1 more status? is
    isSyncing
    field somehow responsible for that? Or we should identify it based on something else? I have changes ready on UI, but now we need to understand what field we are going to use for it. Or Maybe we need to add lastSyncStatus field?
    c
    • 2
    • 4
  • a

    Artem Astapenko

    03/10/2021, 5:19 PM
    Could somebody please approve https://github.com/airbytehq/airbyte/pull/2392/files
    c
    • 2
    • 1
  • a

    Artem Astapenko

    03/10/2021, 5:23 PM
    A bit of story of that change - I decided to upgrade formik lib. We are using 2.1.5. From 2.1.6. there appeared a new property to
    enableReinitialize
    that was actually before was sort of default. However, if I enable those property to fix e2e - it changes a bit form behaviour: when connectorType is changed - form is cleared. So the question is: do we want to clear all the form when connectorType is changed or we would prefer old behaviour, when you can switch different connector types and your old values in input will be still there? ( I assume that we want option 2 thats why I am downgrading package version )
    c
    • 2
    • 3
  • a

    Artem Astapenko

    03/10/2021, 8:35 PM
    Do we have some connector with
    multiline
    property? Or it’s not in master yet?
    c
    j
    • 3
    • 10
  • c

    Chris (deprecated profile)

    03/22/2021, 9:36 PM
    https://airbytehq.slack.com/archives/C019WEENQRM/p1616427854065700
    a
    • 2
    • 3
  • a

    Artem Astapenko

    03/23/2021, 6:18 PM
    I noticed that probably there is some problem with json_schema for hubspot. Investigating it.
    👍 1
    • 1
    • 1
  • a

    Artem Astapenko

    03/23/2021, 9:19 PM
    message has been deleted
    c
    • 2
    • 3
  • a

    Artem Astapenko

    03/23/2021, 9:23 PM
    or we assume that we support all of sync modes right now?
    c
    • 2
    • 15
  • a

    Artem Astapenko

    03/23/2021, 11:20 PM
    message has been deleted
    c
    c
    • 3
    • 28
  • d

    Davin Chia (Airbyte)

    03/24/2021, 11:39 AM
    @Artem Astapenko feel free to merge in https://github.com/airbytehq/airbyte/pull/2546 with https://github.com/airbytehq/airbyte/pull/2405 whenever the frontend changes are ready
    a
    • 2
    • 1
1234Latest