https://linen.dev logo
Join Slack
Powered by
# contributing-to-airbyte
  • c

    charles

    09/16/2020, 5:40 PM
    how would people feel about adding integration tests to PR builds temporarily. it feels like i’m breaking the master build all the time on this. other people feeling this? if not, i’ll just run them myself before merging from now on.
    • 1
    • 3
  • c

    charles

    09/16/2020, 5:47 PM
    i’m looking at master build failures. probably my fault.
    • 1
    • 1
  • s

    s

    09/16/2020, 6:26 PM
    useful tip: if you are looking for docs on how
    tap-singer
    works, Stitch has a ton of docs about it here: https://www.stitchdata.com/docs/integrations/databases/postgresql
    • 1
    • 2
  • m

    Michel

    09/17/2020, 6:15 AM
    Just published how to improve our process to update docs so we can keep the PR review process: https://github.com/datalineio/dataline/pull/327
    • 1
    • 14
  • c

    charles

    09/17/2020, 5:17 PM
    is there a way to run our app using my local file system as mounted workspace as opposed to a docker volume? i thought this was possible, but i’m having trouble figuring it out.
    • 1
    • 3
  • c

    charles

    09/17/2020, 8:58 PM
    for a new integration what are the steps (and can I add them to the docs): • Write integration • Write integration tests • Also write pairwise acceptance test (??? can’t remember if we said this was part of it) • Put this all up for a PR. • Write docs but in a separate PR • Push the image of the integration to docker hub. • Merge both PRs at the same time?
    • 1
    • 19
  • c

    charles

    09/17/2020, 11:13 PM
    For anyone who has written an integration test, do you good way of getting stderr from
    entrypoint.sh
    when running integration tests?
    • 1
    • 6
  • u

    user

    09/17/2020, 11:24 PM
    just to make sure, do we plan to make it more readable?
    • 0
    • 34
  • c

    charles

    09/18/2020, 4:22 PM
    it looks like there’s been a regression on the postgres tap. i’m looking into it.
    • 1
    • 21
  • m

    Michel

    09/18/2020, 9:40 PM
    master has the following warning when I build:
    Copy code
    > Task :dataline-api:generateApiDocs
    'scheme' not defined in the spec (2.0). Default to [http] for server URL [<http://localhost:8001>]
    'scheme' not defined in the spec (2.0). Default to [http] for server URL [<http://localhost:8001>]
    'scheme' not defined in the spec (2.0). Default to [http] for server URL [<http://localhost:8001>]
    'scheme' not defined in the spec (2.0). Default to [http] for server URL [<http://localhost:8001>]
    'scheme' not defined in the spec (2.0). Default to [http] for server URL [<http://localhost:8001>]
    'scheme' not defined in the spec (2.0). Default to [http] for server URL [<http://localhost:8001>]
    'scheme' not defined in the spec (2.0). Default to [http] for server URL [<http://localhost:8001>]
    'scheme' not defined in the spec (2.0). Default to [http] for server URL [<http://localhost:8001>]
    'scheme' not defined in the spec (2.0). Default to [http] for server URL [<http://localhost:8001>]
    'scheme' not defined in the spec (2.0). Default to [http] for server URL [<http://localhost:8001>]
    'scheme' not defined in the spec (2.0). Default to [http] for server URL [<http://localhost:8001>]
    'scheme' not defined in the spec (2.0). Default to [http] for server URL [<http://localhost:8001>]
    'scheme' not defined in the spec (2.0). Default to [http] for server URL [<http://localhost:8001>]
    • 1
    • 4
  • m

    Michel

    09/19/2020, 2:18 AM
    FYI, the connection of currency to csv throws errors:
    Copy code
    airbyte-scheduler | java.lang.RuntimeException: Could not find stream metadata
    airbyte-scheduler | 	at io.airbyte.workers.protocols.singer.SingerCatalogConverters.lambda$toAirbyteSchema$5(SingerCatalogConverters.java:139) ~[airbyte-workers-0.1.0.jar:?]
    airbyte-scheduler | 	at java.util.Optional.orElseThrow(Optional.java:401) ~[?:?]
    airbyte-scheduler | 	at io.airbyte.workers.protocols.singer.SingerCatalogConverters.lambda$toAirbyteSchema$7(SingerCatalogConverters.java:139) ~[airbyte-workers-0.1.0.jar:?]
    airbyte-scheduler | 	at java.util.stream.ReferencePipeline$3$1.accept(ReferencePipeline.java:195) ~[?:?]
    airbyte-scheduler | 	at java.util.ArrayList$ArrayListSpliterator.forEachRemaining(ArrayList.java:1625) ~[?:?]
    airbyte-scheduler | 	at java.util.stream.AbstractPipeline.copyInto(AbstractPipeline.java:484) ~[?:?]
    airbyte-scheduler | 	at java.util.stream.AbstractPipeline.wrapAndCopyInto(AbstractPipeline.java:474) ~[?:?]
    airbyte-scheduler | 	at java.util.stream.ReduceOps$ReduceOp.evaluateSequential(ReduceOps.java:913) ~[?:?]
    airbyte-scheduler | 	at java.util.stre
    • 1
    • 3
  • m

    Michel

    09/19/2020, 3:52 AM
    FYI, I merged the renaming. I also modified the organization and repo name on github
    • 1
    • 1
  • j

    John (Airbyte)

    09/19/2020, 4:44 AM
    most of the website is changed to airbyte. I think I will be done by EOD
    • 1
    • 3
  • c

    charles

    09/21/2020, 10:34 PM
    i’m going to look into better feedback that the app hasn’t started up yet in the UI, unless anyone has anything more urgent they need help on.
  • m

    Michel

    09/22/2020, 5:43 AM
    why do I have an untracked
    api/
    directory when I build?
    • 1
    • 1
  • c

    charles

    09/22/2020, 9:11 PM
    Is there any reason we didn’t push the new pg image for this? https://github.com/airbytehq/airbyte/pull/382
    • 1
    • 15
  • a

    Artem Astapenko

    09/23/2020, 12:18 AM
    guys, what version of intellij idea do you have? I try to set up code style but it throws some error.
    • 1
    • 8
  • c

    charles

    09/23/2020, 12:35 AM
    👍 i don’t have access.
    • 1
    • 1
  • m

    Michel

    09/23/2020, 1:05 AM
    I am not receiving any front end event
  • m

    Michel

    09/23/2020, 1:06 AM
    Syncing currency to PG fails
    • 1
    • 5
  • c

    charles

    09/24/2020, 5:03 PM
    Should we talk about release cycle today? We’re going to start pushing two types of changes 1. hotfixes 2. changes that should be added to next release. there are logistics we need to figure out around this, i.e. having release branches etc.
    • 1
    • 14
  • c

    charles

    09/24/2020, 5:56 PM
    master build started failing. it had been successful on the last commit, but when the build re-ran on the same commit it failed. have meetings starting now, but can take a look after.
    • 1
    • 71
  • c

    charles

    09/25/2020, 12:01 AM
    Added
    new-integration
    label so we can see integration requests easily in the issues list.
    • 1
    • 20
  • c

    charles

    09/25/2020, 1:16 AM
    Master building failing again. Seems unrelated to your changes. Failure in integrations tests with BQ some sort of connectivity issue. I am seeing issues with a lot of other google services in general right now though. Inclined to give it some time and then check back in a bit to see if this is just a google problem.
  • a

    Andy

    09/27/2020, 7:34 AM
    I’m having trouble finding any real source code. Obviously I’m looking at the wrong paths, but I was curious if somebody could please give me the classpath to some postgres connector code? I’m interested in how auth is handled as well various other items. Thanks so much!
    • 1
    • 6
  • a

    Artem Astapenko

    09/28/2020, 4:26 PM
    Is it a known problem or something branch specific? In case the last one - I can investigate more on it.
    • 1
    • 6
  • a

    Artem Astapenko

    10/01/2020, 3:06 PM
    Was something changed in build? Do I need some additional changes to build locally?
    • 1
    • 15
  • s

    s

    10/01/2020, 11:43 PM
    for posterity, the output of reading a singer tap (tap-postgres) with 2 selected streams
    • 1
    • 3
  • s

    s

    10/02/2020, 8:44 PM
    https://github.com/airbytehq/airbyte/pull/479 going once 👀
    • 1
    • 5
  • s

    s

    10/02/2020, 8:59 PM
    the terminology we’re using is misaligned between the product/frontend and the backend. What do you think about the following renames on the data model:
    Source
    -->
    SourceConnector
    Destination
    -->
    DestinationConnector
    SourceImplementation
    -->
    Source
    DestinationImplementation
    -->
    Destination
    • 1
    • 166
12345...24Latest