https://supabase.com/ logo
#off-topic
Title
# off-topic
f

Flyken

07/29/2021, 2:37 AM
hey @User does making a PR that gets merged considered contribution?
oh howdy
c

copple

07/29/2021, 2:38 AM
Sure, let me know the PR?
f

Flyken

07/29/2021, 2:38 AM
cool, one second
someone i don't know actually is apart of supabase staff approved it, idk, i looked at their github profile and they got 2 repo's with no history
they didn't show up in the contrib list on the supabase repo so id
not sure how PR's work in that sense of being "approved" or not
c

copple

07/29/2021, 2:44 AM
I made a few suggested changes. It's close to perfect, just need to add some Nextjs magic 🙂
f

Flyken

07/29/2021, 2:44 AM
no problem, will be done in a few seconds :)
hey quick question
why do you want an
a
element in the Next/Link element?
c

copple

07/29/2021, 2:50 AM
Because crawlers needs to realise it's a link
f

Flyken

07/29/2021, 2:50 AM
next/link replaces the
a
element as it allows for redirection without reloads (its also easier on the server)
oh rgith
woops
one more second
c

copple

07/29/2021, 2:50 AM
Copy code
<Link href="/">
   <a><img src="" /></a>
</Link>
like this essentially
f

Flyken

07/29/2021, 2:51 AM
done
:)
i made the edits on the Flyken271-patch-1 branch, do i need to add them to the PR or make a new one or something?
c

copple

07/29/2021, 2:52 AM
did you push your changes?
f

Flyken

07/29/2021, 2:52 AM
i made the edits in github ui
on my fork
c

copple

07/29/2021, 2:52 AM
OK just commit to the same branch
f

Flyken

07/29/2021, 2:53 AM
how do i do that in the github ui?
c

copple

07/29/2021, 2:54 AM
tbh I'm not sure ... I've never used GitHub UI like that
f

Flyken

07/29/2021, 2:54 AM
:P
c

copple

07/29/2021, 2:54 AM
there should be a way to "commit"?
f

Flyken

07/29/2021, 2:54 AM
hhmm, let me check one more time, if not would a new PR be too much?
c

copple

07/29/2021, 2:55 AM
you could do a new PR, but it's a bit messy. Persist with the current one - it's a good way to learn 🙂
f

Flyken

07/29/2021, 3:04 AM
oh, sorry, i thought it was committing to my current PR but it just made a new one, i really need to get github desktop working (or learn git commands)
sorry
at least the new PR passed
d

dawn

07/29/2021, 3:16 AM
Commit to the same branch?
At the top right of the file list, there should be a drop-down that says "main" or whatever the default branch is
f

Flyken

07/29/2021, 3:17 AM
it just ended up making a new PR, so i figured we could just go off the new one and close the old one
¯\_(ツ)_/¯
d

dawn

07/29/2021, 3:17 AM
Oh that works too
But for the future, you can switch branches here:
f

Flyken

07/29/2021, 3:18 AM
yea
i did that but it didn't reflect the changes in the PR
d

dawn

07/29/2021, 3:18 AM
Oh I see
Interesting
f

Flyken

07/29/2021, 3:19 AM
i got github desktop for future
c

copple

07/29/2021, 3:21 AM
that's perfect, thanks @User
f

Flyken

07/29/2021, 3:21 AM
np :) its not a huge addition but its something
found it when traversing the site looking at the pricing and stuff
thanks