https://supabase.com/ logo
Join Discord
Powered by
hey <@!414972572732489748> does making a PR that g...
# off-topic
f
hey @User does making a PR that gets merged considered contribution?
oh howdy
c
Sure, let me know the PR?
f
cool, one second
someone i don't know actually is apart of supabase staff approved it, idk, i looked at their github profile and they got 2 repo's with no history
they didn't show up in the contrib list on the supabase repo so id
not sure how PR's work in that sense of being "approved" or not
c
I made a few suggested changes. It's close to perfect, just need to add some Nextjs magic 🙂
f
no problem, will be done in a few seconds :)
hey quick question
why do you want an 
a
element in the Next/Link element?
c
Because crawlers needs to realise it's a link
f
next/link replaces the 
a
element as it allows for redirection without reloads (its also easier on the server)
oh rgith
woops
one more second
c
Copy code
<Link href="/">
   <a><img src="" /></a>
</Link>
like this essentially
f
done
:)
i made the edits on the Flyken271-patch-1 branch, do i need to add them to the PR or make a new one or something?
c
did you push your changes?
f
i made the edits in github ui
on my fork
c
OK just commit to the same branch
f
how do i do that in the github ui?
c
tbh I'm not sure ... I've never used GitHub UI like that
f
:P
c
there should be a way to "commit"?
f
hhmm, let me check one more time, if not would a new PR be too much?
c
you could do a new PR, but it's a bit messy. Persist with the current one - it's a good way to learn 🙂
f
oh, sorry, i thought it was committing to my current PR but it just made a new one, i really need to get github desktop working (or learn git commands)
sorry
at least the new PR passed
d
Commit to the same branch?
At the top right of the file list, there should be a drop-down that says "main" or whatever the default branch is
f
it just ended up making a new PR, so i figured we could just go off the new one and close the old one
¯\_(ツ)_/¯
d
Oh that works too
But for the future, you can switch branches here:
f
yea
i did that but it didn't reflect the changes in the PR
d
Oh I see
Interesting
f
i got github desktop for future
c
that's perfect, thanks @User
f
np :) its not a huge addition but its something
found it when traversing the site looking at the pricing and stuff
thanks
PreviousNext
Powered by