Magic links will always have the drawback of requiring an extra browser tab

In apps, this usually isn’t that important since the tab would just open the app again

From a UX point of view, I’d like the magic link to do what it has to do, then close the tab (which won’t always be possible), and original tab would login

Security wise, if you trust email then no issue

For mobile apps, phone auth is more preferred in my opinon.

An SMS can also only be sent to a single device. From that perspective, it's probably a bit more secure, but you're potentially trading convenience.

For desktop, magic link > phone auth

To be fair, I trust email more than sms

SIM cards do get spoofed, and most of the time you won’t know it. On the email side, you’ll have a central authority showing you activity logs

There’s also the recent case where a company offering business services for phone numbers didn’t properly verify customers, so you could claim to be X and route their messages to your system.

I'm not quiet sure about twilio service but usually many phone auth apps charge the sms fee on the user which is quiet annoying

But yeah, you’re trading convenience. At least on desktop. Using a mobile app/website, most phone OSes will auto suggest the code from your sms history.

Which is often even more convenient than other means

But yeah. I’m not a fan of magic links. They have a purpose but it’s not easy to use them without making the UX worse

Agreed.

how do i go about making a PR so i can fix something on the supabase website?

If it's something in the docs, click the 'Edit this page' link at the bottom of the page

its on the actual supabase website

like supabase.io

You have to fork supabase.io web repo before you can create a pull request

hhmm

i can't commit

i keep getting signing key something or another

@User you need to fork the repo, you can't commit directly to Supabase's github account

oh right

@User still can't comit

still says i have no gpg key

You forked the repo, and then git pulled the fork, right?

@User and are you trying to commit the change to your fork?