https://www.dendron.so/ logo
Join Discord
Powered by
# questions
  • p

    p0lyg0n

    09/04/2020, 3:51 PM
    There are two commands you can use (and you can obviously have key bindings)
  • k

    kevins8

    09/04/2020, 3:52 PM
    @User figured out the issue. dendron looks at all your settings to see if you have anything custom. if not, it will add dendron's own defaults to your workspace settings
  • k

    kevins8

    09/04/2020, 3:53 PM
    if you look at the screenshot above, when you set the color theme to default, it removes it from the settings
  • k

    kevins8

    09/04/2020, 3:53 PM
    thus, when dendron looks if there are any custom values set and doesn't find any, it will usher in the light πŸ˜…
  • u

    user

    09/04/2020, 3:56 PM
    I feel like I said exactly this before: ))) > maybe "set to default" is perceived as "not set at all"? I could try some other dark theme)).
  • k

    kevins8

    09/04/2020, 3:57 PM
    you did! though before we also had another issue where we were only checking your workspace settings (instead of ALL your settings)
  • u

    user

    09/04/2020, 3:57 PM
    it's default all the way down))
  • k

    kevins8

    09/04/2020, 3:58 PM
    so two thoughts here: if you explicitly set the default in the json settings, dendron should be able to pick that up "workbench.colorTheme": "Default Dark+"
  • k

    kevins8

    09/04/2020, 3:59 PM
    also thinking that the proper behavior for color theme is to do a onetime information box asking user to confirm if they want to change to the light theme or keep the default theme
  • k

    kevins8

    09/04/2020, 4:00 PM
    > it's default all the way down)) @User 🐒
  • u

    user

    09/04/2020, 4:01 PM
    I don't know why you need to change the color theme at all. Things look pretty good in all of them.
  • k

    kevins8

    09/04/2020, 4:05 PM
    fair point. this was to give folks a visual indicator (especially for regular vscode users) that they were now entering a dendron worksapce (vs a regular code workspace)
  • u

    user

    09/04/2020, 4:08 PM
    that's a fair point too). I don't like the idea of extra information boxes. Can you somehow remember that "we already set color theme for this workspace" and not do it again? So if a user changed it manually you respect their decision).
  • u

    user

    09/04/2020, 4:16 PM
    I'm having a weird minor md preview issue where the check boxes on the live preview are checking the wrong items two bellow I've tried reinstalling the md-preview, is there anything else I can do?
  • u

    user

    09/04/2020, 4:23 PM
    @User no idea what to do, but I just checked and there's something wrong indeed
    Copy code
    # 1
    
    - [x] boo
    - [x] foo
    - [x] bar
    - [x] baz
    
    
    ## 2
    
    - [ ] see
    - [ ] all
    - [x] my
    - [ ] todos
    With content above list number 1 works fine, list number 2 checks things one above what I click. @User
  • k

    kevins8

    09/04/2020, 4:25 PM
    > that's a fair point too). I don't like the idea of extra information boxes. Can you somehow remember that "we already set color theme for this workspace" and not do it again? So if a user changed it manually you respect their decision). @User yep. if you've set a custom theme, that's going to be reflected in the settings and dendron won't touch it. otherwise, if you have the default theme, dendron will prompt you once whether you want to change it and if not, we'll save your response for all future sessions
  • k

    kevins8

    09/04/2020, 4:26 PM
    > I'm having a weird minor md preview issue where the check boxes on the live preview are checking the wrong items two bellow > > I've tried reinstalling the md-preview, is there anything else I can do? @User that's a bug due to the modifications we made for note references. this is the tracking issue: https://github.com/dendronhq/dendron/issues/156 my aim is to fix it by this week's release (next week at the latest)
  • u

    user

    09/04/2020, 4:37 PM
    @User Regarding the color theme - maybe it should change to dendron's preferred theme on install - to give a visual indicator that the install went through and this is now a dendron workspace. But on updates why touch it at all? Either it's already been set to dendron default at install time or the user changed it afterwards. So setting it again is either unnecessary or rude)).
  • k

    kevins8

    09/04/2020, 4:41 PM
    the reason we do this is because we potentially will upgrade your settings with updated defaults on a version change (eg. enabling tab completion by default, making backward compatible changes to the defaults, etc). these setting changes are only made to your workspace and our algorithm for determining whether we can make the change is by checking if the user has set it to a non-default value
  • u

    user

    09/04/2020, 4:46 PM
    oh, so you don't want to make a special case for color theme setting I admire the purity of this approach but on the other hand I'm annoyed that I have to go and edit some json now to keep the app from blinking every day 😁
  • k

    kevins8

    09/04/2020, 4:47 PM
    @User actually, i will make a special case for the color theme setting πŸ˜… i worked at amazon for 5 years so i'm totally willing to make compromises for the sake of user experience
  • k

    kevins8

    09/04/2020, 4:48 PM
    (now if I had worked at google, that would be a different storyπŸ™ƒ )
  • u

    user

    09/04/2020, 4:49 PM
    ok, I take back all my snark) ❀️
  • k

    kevins8

    09/04/2020, 4:50 PM
    you can take it back when your workspace stops blinking on upgrades πŸ˜… (which should be after today)
  • p

    p0lyg0n

    09/04/2020, 4:52 PM
    Although I haven't figured out a solution for the multi-line regex issue. And I haven't found a way to grab the user's text selection from multiple cursors either... All I found was
    vscode.window.activeTextEditor.selection
    that gives back the selection range (not the text) for the first cursor I guess
  • p

    p0lyg0n

    09/04/2020, 4:52 PM
    Any ideas @User ?
  • u

    user

    09/04/2020, 4:56 PM
    @User I installed it and it worked for my toy example case ). I don't have many tags in Dendron, was just curious if they were a good idea at all I don't know about cursors, in a perfect world I guess I'd run your command and click on tags in preview to add them to query. Tap, tap, tap and go))
  • k

    kevins8

    09/04/2020, 4:57 PM
    @User the extension looks awesome. downloading it now! as far as multiple cursors goes, I don't know if vscode exposes that as an api
  • p

    p0lyg0n

    09/04/2020, 4:58 PM
    This was a great excuse to get my feet wet with VS Code's API and extension's ecosystem
  • p

    p0lyg0n

    09/04/2020, 4:58 PM
    Although I gotta say, it was a bit difficult trying to find the right APIs to use... :/
1...444546...757Latest