chmac
01/27/2022, 12:57 PMhikchoi
01/27/2022, 12:58 PMchmac
01/27/2022, 1:00 PMhikchoi
01/27/2022, 1:00 PMchmac
01/27/2022, 1:02 PMchmac
01/27/2022, 1:03 PMchmac
01/27/2022, 1:03 PMhikchoi
01/27/2022, 1:03 PMhikchoi
01/27/2022, 1:06 PMhikchoi
01/27/2022, 1:07 PMchmac
01/27/2022, 1:08 PMhikchoi
01/27/2022, 1:10 PMchmac
01/27/2022, 1:13 PMchmac
01/27/2022, 1:14 PMDEBUG='*' dendron ...
but that doesn't seem to work.chmac
01/27/2022, 1:15 PM--version
does produce output, as does --help
, but neither one produces an error despite being added to the end of a different command...chmac
01/27/2022, 1:17 PMnotes
instead of note
, will file a bug.kevins8
01/28/2022, 2:24 AMkevins8
01/28/2022, 2:24 AMLOG_LEVEL=debug
before running the CLIlukecarrier
01/28/2022, 8:03 PMgood first tasks
that will help introduce you to the code while also making a noticeable contribution to an existing feature. Each of these tasks should take no longer than an hour to complete end to end. If you choose to take one on, a member of the Dendron team will help walk you through the process -- just leave a comment on the issue.
Here are this week's tasks:
- [#2238: Move Header Should Have Current Hierarchy Prefilled](https://github.com/dendronhq/dendron/issues/2238)
- [#2186: Prompt "are you sure?" before deleting .next directory with publish init command](https://github.com/dendronhq/dendron/issues/2186)
- [#2300: CLI does not report invalid commands](https://github.com/dendronhq/dendron/issues/2300)
For help getting set up, see our [contributing docs](https://wiki.dendron.so/notes/81da87be-2d4e-47b5-a1d6-c0d647e1ab00/).l2dy
01/29/2022, 3:44 AMkevins8
01/29/2022, 4:28 AMwithnoroof
01/30/2022, 12:00 PMkevins8
01/30/2022, 9:27 PMSeriousBug
01/31/2022, 7:24 PMproc.use(wikilinks, opts)
).
With V4 these options were both attached to the plugins, and also added to the proc data (because there are some places where plugins other than the intended one need access to the opt). I'm wondering if that's the best way to handle this though. We could instead do:
- All opts should be in proc data. Don't pass them into the plugins, have the plugins get it from proc data.
- All opts should be passed to plugins only, never to data. If more than one plugin is interested in those opts, we can pass the opts to them as well.
I'm actually leaning a bit towards the former option because it's much more flexible. It does make these plugins even more tightly coupled with Dendron, e.g. someone couldn't grab these plugins without the rest of Dendron's proc. I think that's an okay tradeoff at the moment, and we can always come back and refactor this code if we want to make the plugins available outside of Dendron.kevins8
01/31/2022, 7:40 PMSeriousBug
02/01/2022, 7:57 AMdendronPub
plugin even when the destination is not HTML or flavor set to publishing?kevins8
02/01/2022, 2:43 PMjyeung
02/08/2022, 6:26 AMSeriousBug
02/08/2022, 8:32 AMkevins8
02/08/2022, 5:34 PM