https://www.dendron.so/ logo
Join Discord
Powered by
# dev
  • u
    > error running command: Cannot read property 'dailyDomain' of undefined getting this error today when trying to create new daily journal
  • k
    This is an issue with upgrading to 0.47.0. If you are encountering this, you'll want to copy the following into 
    dendron.yml
    Copy code
    yml
journal:
    dailyDomain: daily
    name: journal
    dateFormat: y.MM.dd
    addBehavior: childOfDomainNamespace
    firstDayOfWeek: 1
  • u
    @User is it the dendron.yml inside workspace? It's working after adding the snippet there, but the journal is getting created as 
    org-workspace/seeds/dendron.dendron-site/vault/daily.journal.2021.06.23.md
    . How do I make it so that it gets created inside org-private?
  • k
    notes are created in the same vault as the current opened note
  • k
    so if you open a note in org-private, you can create a journal there
  • j
    Thanks for chasing this one down. I'm working on a fix that should hopefully make import notes more robust - it'll now pop an error showing which files it had issues on, and import the rest.
  • k
    @User - we've got a special event planned for today (starting now) called the greenhouse. Our very own @SeriousBug is giving a talk on data races. Recording will be available after the talk.
  • k
  • v
    @kevins8 reading the RFC I realized that text decorations are very useful. Couldn't we use them to for example display an embedded note content??
  • k
    we could. decorators have a few limitations (eg. you can't c/p decorated content, they won't shift text down bu rather occlude, etc)
  • k
    for embedded not content, if not using the preview, @User recently made a change so that hovering over note references displays just the part referenced. we're also lookiing into adding a mini preview in the side panel to be able to preview content without opening up a full preview
  • v
    That's really cool, I remember that there was some efforts to render images and other content dinamically in the vscode editor.
  • v
    Actually I find weird that nobody has attempted to fork vscode to create a subset of it's features for note taking
  • k
    yeah, its something we've discussed in terms of a standalone dendron. this could be in the form of a hard fork (actually had a prototype of this before I decided it was too much maintenance at this stage), a theia build (I believe https://replit.com/ does this), or a standalone client built from scratch. no ETA on this yet 😅
  • k
    @User We published a post today about the dendron seed bank. tldr - its an open registry for general knowledge and its open for business. Any and all feedback welcome 🙏 https://blog.dendron.so/notes/qTeL51LFD0Y8uC9ect7QV.html
  • s
    Does Dendron do anything special to pass the notes to the regular preview? I'm especially interested in how local image files get resolved (e.g. 
    ![](/assets/foo.png
    ). The same link works in the preview, but not in the hover. It does work in hover if I turn it into an absolute path (e.g. 
    ![](/home/user/Dendron/vault/assets/foo.png
    ) though, so it's an issue of finding the image.
  • k
    for preview, we default to the logic in markdown preview enhanced. for relative image paths, i believe this tries to append the image to the folder where the note is in
  • s
    Okay, the basic preview must be doing the same, but the hover isn't. Thanks.
  • h
    is 
    NotePropsDict
    just a wrapper around key-value pairs of 
    NoteProps
    and their ids? I see a few 
    _.values(engine.notes)
    around but it seems like it's not grabbing anything out of the dict. wondering what I'm blanking on here 😅
  • k
    yep
  • h
    any idea why console.logging 
    engine.notes
    shows me all the kvps but 
    _.values()
    return an empty array? same thing for 
    Object.values()
  • k
    hmm, it shouldn’t. do you have an example snippet?
  • h
    Copy code
    const getUnreferencedLinks = ({
  ast,
  note,
  engine,
}: {
  ast: DendronASTNode;
  note: NoteProps;
  engine: DEngineClient;
}) => {
  const textNodes: Node[] = [];
  visit(
    ...
  )
  const unreferencedLinks: UnreferencedLink[] = [];
  
  // this will print kvps of all notes correctly.
  console.log(engine.notes);

  // this is an empty array.
  const notes = _.values(engine.notes);
  console.log(notes);

  _.forEach(notes, (note) => {
    ...
  });
  return unreferencedLinks;
}
  • h
    omitted some irrelevant stuff, but nothing special is going on. just trying to get all the notes from the engine and do stuff with it.
  • k
    hmm, what happens when you drop a 
    debugger
    in there?
  • k
  • k
  • h
    hmm. I don't have a test that uses this yet 😅
  • k
    i would just create one. its the fastest way to debug this issue 🙂
  • h
    one sec.
1...727374...108Latest