the issue is that remark2rehype is converting the

<a>...</a>

tag into

<p>...</p>

i would try rendering it as a rehype node directly when compiling for html. see an example of it here -> https://github.com/landakram/remark-wiki-link

@User 👆

@User I'm looking at the Lookup controllers and providers as a reference to add those components to the doctor command. There are V2 and V3s of these components. Which one should I base the components for the doctor command? It looks like Lookup controller V2 is still used in the main lookup command but V3 is used in other commands that utilizes lookup.

v3 is the new one that i'm planning on replacing v2 with. use the patterns from v3

got it 👍

Should have figured this out earlier, sorry, but it looks like what I'm attaching to the compiler doesn't even get executed:

function attachCompiler(proc: Unified.Processor, opts?: PluginOpts) {
  const Compiler = proc.Compiler;
  const visitors = Compiler.prototype.visitors;
  debugger;

  if (visitors) {
    visitors.blockAnchor = function (node: BlockAnchor): string | Element {
      debugger;

I'm hitting the first break point, but never the second one. I tried outputting a hast node directly, but it doesn't really matter because the function doesn't even get called.

oh, i get whats happening. the

compiler

only gets called when its compiling the corresponding node type. because we are calling

remark2rehype

, the node type gets converted to a

rehype

node which is why the compiler never calls it. we use a transformer,

dendronPub

(https://github.com/dendronhq/dendron/blob/dev-kevin/packages/engine-server/src/markdown/remark/dendronPub.ts#L157:L157), which runs after parsing but before compilation to transform the remark nodes into rehype nodes.

Thanks a lot!

np - i should have caught this in the code review. its been a while since I touched the unified code you'll want to create a case statement in

dendronPub

which takes an anchor and converts it into the corresponding html output. you can see tests for it here: https://github.com/dendronhq/dendron/blob/dev-kevin/packages/engine-test-utils/src/__tests__/engine-server/markdown/dendronPub.spec.ts#L101:L101

It finally works, thanks again!

@User @User heads up that I updated the dendron-site docs about our markdown parsing architecture: https://wiki.dendron.so/notes/dc72e684-8ff8-4c41-a2f7-93fc14ee0d6a.html very minimal right now so please add on as you guys are working on it 🙏

did you just push? it's 404ing

yep. takes ~1min to udpate

live now

@User pr looks good, just left a few minor comments https://github.com/dendronhq/dendron/pull/766#pullrequestreview-670645665

hmm... still 404 for me

I can see it fine

🤔

me too

can see it fine, I mean

probably some github CDN cache issue. I think

can you clear the cache on your browser or try a different one?

did try that. 404s on all of them. tried on mobile as well. still nada.

well. I think the CDN dropped the cache now

I can see it now

i think github is also slow to refresh its cache internationally. planning on moving this to dendron managed hosting soon - we do near instant cache invalidation globally 🚀

yeah. it's raining here in Korea so I'm suspecting things are gonna be slow here 😄 (outrageous made-up claim that my jetlagged brain came up with btw)

Out of curiosity, should we see a visual different when we enable the new tree view?

If you enable it, you will see a second view alongside the original one

well that's interesting then.