Their are still two parts that I need to write about xD so after they are finished I will change the state may take me till the weekend. But thanks for the first feedback

In DendronASTData, when would

fname

be ever undefined? It's defined as

fname?: string;

, but I tried changing it so it's not optional and everything still compiles correctly.

ASTData is used when compiling dendron markdown. in the past, we used to do this without passing in a

fname

since converting, say wikilinks to markdown links, didn't require the current file name. as we added additional features,

fname

became needed to generate backlinks and other details that required the current filename. we didn't make it required from the get go because we still had a bunch of code that didn't pass it in but that's been changing over time so if it compiles and all the tests pass, then make it non-optional 🙂

Got it, thanks!

@here - thank you all for contributing to Dendron! Without a strong community, Dendron would not be where it is today. We are just getting started. We want to make it easier to recognize our fellow community members so we've revamped the readme page, enabled the all contributors bot (https://allcontributors.org/docs/en/bot/usage) and added a list of contributors (https://github.com/dendronhq/dendron#contributors-). In the future, if you'd like to credit someone for work, you can simply ask the contribution bot:

@all-contributors please add @<username> for <contributions>.

You can either use this bot in the relevant Github issue OR in our long-running gratitude issue here: https://github.com/dendronhq/dendron/issues/714

I finished the Workspace Sync command stub. Any ideas for testing it? I saw that the existing Add and Commit command doesn't have tests either, and neither does the Dendron CLI commands for these. I could add tests for all of them.

Yeah, we actually added some test utilities that made this easier. See [GitTestUtils](https://github.com/dendronhq/dendron/blob/dev-kevin/packages/engine-test-utils/src/utils.ts#L22:L22) for automatically creating a workspace. You can see it being used [here](https://github.com/dendronhq/dendron/blob/dev-kevin/packages/engine-test-utils/src/__tests__/engine-server/workspace.spec.ts#L21:L21)o To do the tests, we can use

tmpDir

to setup a local remote. Use

GitTestUtils

to create a repo and then push an dpull to the local remote

i've updated the site documentation docs about git tests. if you run into anything else thats helpful while doing this, feel free to add it there: https://wiki.dendron.so/notes/cb22bd36-d45a-4ffd-a31e-96c4b39cb7fb.html#git-related-tests

Why do I have the feeling that I actually like writing RFC's for dendron too improve it, but either don't use dendron as much as I could, or that I actually am a bit intimidated by the code base to implement some of the proposed changes xD but hey at least I already wrote a basic json-schema for schema files and verified that they actually work xD

its all about finding a place to start 🙂 we've been building up a good list of good first tasks now (https://github.com/dendronhq/dendron/labels/size.small) so if you do want to start sometime, just let me know and happy to help you through the process

@User update on the ant themes - it slipped last weeks release but will be a priority this week. will ping you when it gets merged!

hey @User wanted to let you know that @User is currently working on a completely redesigned graph view for dendron (https://wiki.dendron.so/notes/c998c642-a748-4f77-9285-cfec35330251.html). let us know if you have any recommendations for visualization libraries 🙂

That list looks juicy for a js newbie like me 🌱

Echoing what Kevin said, any feedback/suggestions are always welcome – I'll be sharing a design document PR detailing project library/timeline plans sometime tomorrow, so keep an eye out for that if you're interested!

What it's the library you guys are thinking of? I don't see d3.js in the RFC for example, I think that is the one that obsidian uses

d3 is what we're currently thinking about but henry will be doing a deep dive this week to see if there are better alternatives

just updated this issue with more detailed instructions in case your interested 😇 https://github.com/dendronhq/dendron/issues/613

Ah, that's awesome! Thanks for the ping. I recently rounded up some options here for a non-dendron project that was also investigating node-link layouts @User https://gist.github.com/hydrosquall/cf6a68305fb14e9fb45c82cbcbff0c65 My personal opinion would be to get started with cytoscape.js or vis.js's network option, as they'll let you get started with a bunch of useful network interaction primitives that aren't as low-level as d3, then only eject to writing a custom renderer when you realize you have interaction needs that aren't supported by these high level libs. The Alibaba renderer demo is also nice (it has built in support for collapsible/expandable nodes), but I can't vouch for it as I haven't used it in a project myself. As far as D3 is concerned, I think using the

d3-force

package for composing a force layout is convenient, but wouldn't recommend using it for actually drawing/updating things in the DOM via the

d3-select

.

xD The tasks are not the Problem xD It's more like I'm rusty in Typescript xD I'm forbidden to use Typescript at work, we need to use Vanilla JS. In some way it is understandable, our dev lead just doesn't trust the transpilation. Secondly we are using Vue at work and not React, Thirdly i'm using Php most of the time. And as the fourth point it's more like Monorepos are nice but scary on the other side since they are overwhelming.

TypeScript isn't too bad, you just write code as usual until the type checker starts complaining 😄

(I am very happy with TypeScript's type system though, it's surprisingly powerful)

I know I want to use it at work but I'm not allowed to xD

Dendron could be your type haven 😄

The new hooks are great! But I do miss a more advanced example.. Hope it is possible to both wait for input (

VSCodeUtils.showInputBox

?), and rename a note on an

onCreate

hook.. Or will that break the design of them in bad ways?

hmm, could you elaborate on this?

Will do when I'm back on the pc :)

The guys of you that like schemas may want to take at the following repo where I'm going to work on creating a Custom Editor for them, currently it only provides Validation for the

*.schema.yml

files more to come in the future https://github.com/flammehawk/dendron-schema-util

ooh validation 😄 love it.

be aware you will need Red Hats YAML extension for the validation to work

is this installable?