@User you're right, this is a bug and there's an issue for it here: https://github.com/dendronhq/dendron/issues/227 feel free to upvote to help us prioritize 🙂

is the

LookupProvider

exposed somewhere when I instantiate the lookup command with

await new LookupCommand().execute()

? How do I trigger

onDidAccept

after executing the lookup command?

nvm. I think I figured it out. 😄 I THINK

will clean up and submit a PR soon

i'm awake now so let me know if you have more questions 😅

I didn't add a multi-vault test because it felt kinda pointless as the extraction comes from outside a known vault. should I do it anyways? or are the multi-vault tests only for interactions within the known vaults?

also, I was gonna add more tests for selectExtraction in general because there weren't any, but didn't want to introduce noise to the PR. I'll add them on a separate PR or just add more onto this one whichever you prefer.

I am half awake half dead atm so I'll submit tomorrow and let you know.

totally didn't forget to push after dinner 😄

sounds good. no need for multi-vault test

and never push on an empty stomach 🙂

https://github.com/dendronhq/dendron/pull/471 take a look when you have a chance 🙏

just merged! great work @User 🌱

trying to write an issue to add more test cases for

selectExtraction

. would the

Work Item

template be for something like this?

also, I've started keeping the output pane on while I use dendron. I felt like I was struggling to figure out what's internally happening in dendron when I was working on the codebase 😄 I think this will help a lot. any other tips?

yep 🙂

Dendron has a lot of moving parts so I try to divide my workspace accordingly. - 1: What I'm working on - 2 and 3: Related project (eg. if 1 was the plugin, 2 & 3 might be

engine-server

and

api-server

respectively) - 4 and 5: This is where I keep common utils/libs (eg.

common-all

, type definitions, etc) Since your screen space can be pretty small when doing this, I use the following keyboard shortcut to trigger maximizing panes

json
{ 
    "command": "workbench.action.toggleEditorWidths",
    "key": "ctrl+cmd+m"
}

I also try to document the main logic when I run into it in the {project}.internals hierarchy on our site: https://dendron.so/notes/4b8f0470-dacb-433b-8d0c-f5a7d8f5245d.html

5 splits 😄 I can barely handle 3

> I also try to document the main logic when I run into it in the {project}.internals hierarchy on our site I was just thinking about this yesterday too. But on my own site just as my personal cheatsheet

@User just checking if the failed plugin tests are not on my end. are these the same tests that were failing the last time I pushed?

cuz this time integ tests are failing when I run it locally as well.

about to start an onboarding but will be checking out the tests afterwards!

Take your time 😄

just left a comment 🙂

Just pushed a fix.

and a comment.

merged 🙂

👍 on to the next issue.

let me know if your interested in any of the bigger tasks and i can walk you through the process if there are any that catch your eye 😇 https://github.com/dendronhq/dendron/issues?q=is%3Aopen+is%3Aissue+label%3Asize.mid

not sure if I'm ready for that haha