https://www.dendron.so/ logo
Join Discord
Powered by
# dev
  • k

    kevins8

    01/17/2021, 9:53 PM
    its true that react isn't required for the components we want to build. react does have momentum and a rich ecosystem of pre-made components that help cut down on the amount of things we need to build from scratch along with tooling prior work in which to build it
  • s

    Simon-Claudius

    01/17/2021, 9:55 PM
    I worked with React before, but the fact that it's by Facebook makes me really reluctant to use it again. Funny how that works.
  • s

    Simon-Claudius

    01/17/2021, 9:56 PM
    shudders
  • k

    kevins8

    01/17/2021, 10:09 PM
    as for previews, 11ty is definitely an option. we can even use next.js to serve it statically. building additional features like scroll sync, interactivity, etc, would be harder to to and would eventually have us looking for more feature rich solution (eg. nextjs + react)
  • k

    kevins8

    01/17/2021, 10:11 PM
    yeah, I know that facebook properties can elicit strong reactions. that being said, I think its far enough along and widely adopted that it makes sense to build on top of. a comparison i would draw is browsers and chromium. while part of me wishes for more diversity in the ecosystem, now that every browser (and electron) besides firefox has standardized on chromium, its hard to justify not building on top of it
  • s

    Simon-Claudius

    01/17/2021, 10:16 PM
    Sure, I understand. It is fair. Besides criticism it deservers as a company, Facebook's variant of social media is terrible for my mental health, so my reaction is partly emotional/personal ;).
  • k

    kevins8

    01/17/2021, 10:54 PM
    that’s why we’re on discord πŸ˜…
  • s

    Simon-Claudius

    01/17/2021, 10:54 PM
    πŸ˜„
  • f

    fudo

    01/18/2021, 5:39 AM
    Yeah for me its more like just prefering vue over react xD
  • b

    Bassmann

    01/18/2021, 7:40 PM
    I couldn't get it to work. Not sure what's wrong. My
    dendron.yml
    looks like this version: 1 lookupConfirmVaultOnCreate: true useFMTitle: true vaults: - fsPath: vault name: Notes - fsPath: repos\potential-adventure name: GitJournal - fsPath: repos\solid-octo-dollop name: Knowledge Base site: copyAssets: true siteHierarchies: - root siteRootDir: docs usePrettyRefs: true duplicateNoteBehavior: action: "useVault" payload: vault: fsPath: vault
  • b

    Bassmann

    01/18/2021, 7:41 PM
    Is duplicateNoteBehavior a top level entry or a subentry of site?
  • k

    kevins8

    01/18/2021, 9:07 PM
    its a subentry of site. fsPath should be a subentry of vault
  • k

    kevins8

    01/18/2021, 9:07 PM
    eg.
  • k

    kevins8

    01/18/2021, 9:07 PM
    Copy code
    duplicateNoteBehavior:
            action: useVault
            payload:
                vault:
                    fsPath: notes
  • s

    Stephen

    01/19/2021, 7:56 PM
    Does anyone else do dev debugging on windows? Going through setup https://dendron.so/notes/64f0e2d5-2c83-43df-9144-40f2c68935aa.html#getting-started and running debug run extension plugin core yields a new code window with an error:
    Copy code
    Activating extension 'dendron.@dendronhq/plugin-core' failed: Cannot find module '@dendronhq/common-all'
    Require stack:...
    I still have some explanations to rule out but might just try WSL. Any caveats or hints would be welcome πŸ‘
  • k

    kevins8

    01/19/2021, 8:19 PM
    hmm, @User probably has the most experience doing this on windows. i just setup dendron using straight up powershell when working through publishing issues so I can tell you it did work πŸ˜…
  • k

    kevins8

    01/19/2021, 8:20 PM
    where did you get the error? (eg. after bootstrap)
    Copy code
    npm run bootstrap:bootstrap
    npm run-script bootstrap:build 
    npm run-script bootstrap:build:plugin-core:sync-vault
  • s

    Stephen

    01/19/2021, 9:48 PM
    rebooted + fresh checkout = it's good!
  • k

    kevins8

    01/19/2021, 9:54 PM
    πŸ‘
  • h

    hikchoi

    01/19/2021, 10:56 PM
    @User I remember you mentioning commit message convention notes. I can't seem to find them in the dendron website. Should I follow https://www.conventionalcommits.org/en/v1.0.0/ ?
  • k

    kevins8

    01/19/2021, 11:05 PM
    i've not added it yet. updating docs now
  • k

    kevins8

    01/19/2021, 11:05 PM
    style guide pasted below πŸ™‚ - we follow [conventional commits](https://www.conventionalcommits.org/en/v1.0.0/) with the following tags - categories: - feat: feature - introduce new functionality - enhance: enhancement - improve existing functionality - fix: make something not broken - chore: backend improvements - spike: not complete commit
  • h

    hikchoi

    01/19/2021, 11:06 PM
    great πŸ‘
  • h

    hikchoi

    01/19/2021, 11:07 PM
    I'll just squash my changes into one commit that follows the category and submit a PR
  • k

    kevins8

    01/19/2021, 11:11 PM
    πŸ‘
  • h

    hikchoi

    01/20/2021, 12:10 AM
    https://github.com/dendronhq/dendron/pull/458 submitted and signed. but it seems like the Integ test is failing? gotta run so I'll look at it later tonight
  • k

    kevins8

    01/20/2021, 12:54 AM
    the failures were because of me - i'm pushing new changes πŸ˜… as for the PR, left some comments πŸ™‚
  • h

    hikchoi

    01/20/2021, 1:05 AM
    Gotcha.
  • s

    Stephen

    01/20/2021, 2:46 PM
    I think I've found a worthwhile feature that is within my reach. Instead of using vscode anki, I can setup an export pod that sends to notes to anki based on schema/template patterns. The benefit is that hierarchy navigation allows the cards to be used for review within vscode where they're easier to edit to begin with. One of the main reasons I find this important is that there remains no end-to-end math to spaced repetition format solution (systems like Notion or Remnote work, but the bottleneck is ingress). Once the format of study cards has matured a bit, maybe we could introduce status parameters within the frontmatter of flashcards for vscode-native spaced-repetition review. For now, I'm seeing this project as a gentle practice with a number of useful topics ie, ts/extentions/tests.
  • k

    kevins8

    01/20/2021, 4:22 PM
    I think that would be a great addition. dendron pods also need some love since I've been focusing on publishing for the last few releases πŸ˜… if you feel good about taking this on, I can provide some sample code and documentation to help you get started
1...464748...108Latest