https://www.dendron.so/ logo
Join Discord
Powered by
# dev
  • l

    lukecarrier

    01/02/2021, 9:54 PM
    https://giphy.com/gifs/laff-tv-comedy-himym-how-i-met-your-mother-lOmxas40IS3cL8BKvL
  • l

    lukecarrier

    01/02/2021, 9:55 PM
    (seriously though, thanks, we'll get a WSL1 test in)
  • l

    lukecarrier

    01/02/2021, 9:58 PM
    execa doesn't correctly escape spaces on Windows, so
    git commit -m 'initial commit'
    is executed as
    ["git", "commit", "-m", "'initial", "commit'"]
    . This might be enough Windows for one day πŸ˜…
  • h

    hikchoi

    01/02/2021, 9:59 PM
    that's extremely frustrating 😩
  • h

    hikchoi

    01/02/2021, 9:59 PM
    good morning btw
  • k

    kevins8

    01/02/2021, 10:31 PM
    argh, that's a pain. maybe we can kebab case it
  • h

    hikchoi

    01/02/2021, 10:35 PM
    so, general question regarding contributing: I grabbed https://github.com/dendronhq/dendron/issues/417 as this was suggested as a good first task, and the actual task is simple enough. But I'm struggling to add proper test cases because I'm juggling getting used to Dendron internals, typescript in general, the various toolings used all at once. (as well as just getting used to using dendron in my daily workflow) I'm sure this will all come as I work on it, but I'm not sure of the open source etiquette of this. Should I yield and let other people work on this issue and look for other low hanging fruits first? Perhaps spending some time using dendron and contributing to various documents could be more immediately useful for my situation.
  • k

    kevins8

    01/03/2021, 12:26 AM
    so that depends on your apptetite. if you down, happy to do a pairing session sometime to go over tests or add more documentation to them. if they seem a little much now, you can also send a pull request for what you have and i can write the tests and commit them as part o ffuture documentation
  • h

    hikchoi

    01/03/2021, 12:31 AM
    oh a pairing session would be super helpful πŸ˜„ I'm currently going through the TypeScript Handbook so at least I don't keep context switching between dendron and typescript specifics.
  • k

    kevins8

    01/03/2021, 2:27 AM
    cool, just sent you a calendly πŸ™‚
  • h

    hikchoi

    01/03/2021, 2:29 AM
    got it
  • k

    kevins8

    01/03/2021, 11:27 PM
    @User I updated the testing docs for the plugin here: https://dendron.so/notes/c84aa95c-83b9-4d52-90a1-eeec8f0ca84f.html Also left some comments on the Dendron pod test here: https://github.com/dendronhq/dendron/blob/master/packages/plugin-core/src/test/suite-integ/PublishPod.test.ts#L40:L40 As for typescript and javascript, I would recommend the following resources: - primer to typescript (everything in Dendron is based on this): https://www.typescriptlang.org/docs/handbook/typescript-from-scratch.html - go through the javascript course: https://www.codecademy.com/learn/introduction-to-javascript still have a lot more to document but this is the start πŸ™‚
  • h

    hikchoi

    01/03/2021, 11:31 PM
    πŸ‘
  • h

    hikchoi

    01/03/2021, 11:32 PM
    I'm half way through the ts handbook. Will look into the comments later
  • h

    hikchoi

    01/03/2021, 11:44 PM
    @User > Also left some comments on the Dendron pod test here: https://github.com/dendronhq/dendron/blob/master/packages/plugin-core/src/test/suite-integ/PublishPod.test.ts#L40:L40 hmm I don't see a comment there. Did you mean something else?
  • k

    kevins8

    01/03/2021, 11:45 PM
    ah, didn't push. here you go (its just a few lines): https://github.com/dendronhq/dendron/blob/master/packages/plugin-core/src/test/suite-integ/PublishPod.test.ts#L39:L39
  • h

    hikchoi

    01/03/2021, 11:46 PM
    hehe
  • h

    hikchoi

    01/03/2021, 11:46 PM
    thank you!
  • l

    lukecarrier

    01/05/2021, 9:17 PM
    @User I'm getting caught up in my day job atm and I'm not sure when I'll get back to working through the Windows CI issues. Are you happy to go with macOS and Linux for now and I'll try to pick this back up over the weekends?
  • l

    lukecarrier

    01/05/2021, 9:18 PM
    It looks like most of the tests suffer promise rejections due to file operations, and some of them look like renames of files with open handles, which will need some redesigning I think
  • k

    kevins8

    01/05/2021, 9:42 PM
    absolutely! appreciate the work you've done. we can temporarily disable windows tests on the CI until we get that worked out.
  • l

    lukecarrier

    01/05/2021, 9:43 PM
    I will jump back on it, I'm just conscious there's value in having some coverage in the meantime
  • k

    kevins8

    01/06/2021, 5:12 AM
    @User let me know when you are ready with the pull request for the changes that you have in the meantime, i started keeping a journal on some dev work i'm doing. find it to be therapeutic. mostly about aws at the momentπŸ˜… posting in case others find it useful: https://www.kevinslin.com/notes/6b8b5cf5-fb01-422e-a3d9-e1fad26ae13c.html
  • k

    kevins8

    01/08/2021, 10:52 PM
    @User did you submit a pull request for the CI tests? going to make some changes to the internal apis and want to not cause extra integration work πŸ™‚
  • l

    lukecarrier

    01/09/2021, 12:29 AM
    Go ahead, I don't mind rebasing! I'm planning to remove the Windows build and submit what I have tomorrow
  • f

    fudo

    01/12/2021, 3:33 PM
    @User how would one go about supporting you with the github issues, meaning labeling them usw. And is their a currently an up to date board for the issues?
  • k

    kevins8

    01/12/2021, 4:26 PM
    I can give you access to triage issues in the repo if you want to help. wrote a small guide on labels here: https://dendron.so/notes/1e6c8b49-ef88-4e79-b2df-e9d614c38a53.html If anyone else is interested, ping me on this thread. Moving forward, I also want to do a best of the backlog session where users can vote on one small and big initiative for us to work on for a given week/month. Also open to other ideas.
  • f

    fudo

    01/12/2021, 4:33 PM
    Thats why i asked so feel free
  • k

    kevins8

    01/12/2021, 4:50 PM
    just added you. you should see an email/notification on github
  • h

    hikchoi

    01/12/2021, 8:12 PM
    this looks like a good way to get myself more involved. interested as well
1...434445...108Latest