https://www.dendron.so/ logo
Join Discord
Powered by
# dev
  • t

    tsnieman

    11/13/2020, 5:04 AM
    Oh, hm. I've never used
    lerna
    before, though i've seen it around a lot. I'll give it a go - thanks ๐Ÿ‘
  • t

    tsnieman

    11/13/2020, 5:10 AM
    That lets me import it more easily - but the imported file (class with static properties) is still invalid. Seems like we've gotta get the babel configs in-sync (or, more broadly, make the packages able to nice together).
  • t

    tsnieman

    11/13/2020, 5:12 AM
    My first attempt at extending next sever's babel config (https://nextjs.org/docs/advanced-features/customizing-babel-config) with seemingly the appropriate plugin (https://babeljs.io/docs/en/babel-plugin-proposal-class-properties) didn't work; I can see the next server picking the babel config file up, but I get the same error. Could be that webpack loaders needs some special coercing on top of that based on the message, though.
  • k

    kevins8

    11/13/2020, 5:25 AM
    you want to use this line:
    import {...} from @dendronhq/engine-server
  • k

    kevins8

    11/13/2020, 5:25 AM
    the autocomplete in vscode is a lie
  • k

    kevins8

    11/13/2020, 5:25 AM
    you shouldn't need to do anything with babel-config
  • t

    tsnieman

    11/13/2020, 5:35 AM
    halfway there...
    console.log({ DConfig })
    shows up in the console, but the webview is broken because of a
    tls
    dep from
    common-server
    ๐Ÿค”
  • k

    kevins8

    11/13/2020, 5:36 AM
    oops, thatโ€™s an issue on my part. itโ€™s because tls is a node dependency. can you copy the DConfig into next-server for now? will fix this tomorrow morning! ๐Ÿ˜…
  • t

    tsnieman

    11/13/2020, 6:01 AM
    formik + antd.
  • l

    lukecarrier

    11/13/2020, 11:08 AM
    As I was going over the Dendron site repo today I noticed that there are some good starting points for best examples on different note taking styles (PARA, Zettelkasten, amoeba, bullet journaling). For the more organisational patterns, should we consider multiple templates? If we did, how do we make them easy to get started with on GitHub -- branches or different repositories?
  • l

    lukecarrier

    11/13/2020, 11:09 AM
    I'm thinking separate repositories because I don't think template repos allow you to select a branch and that might bury them
  • k

    kevins8

    11/13/2020, 3:28 PM
    @User I like the multiple repositories approach. this way, when we officially launch multi-vault at the end of the month, folks should be able to just import the template they want from inside dendron
  • k

    kevins8

    11/14/2020, 2:37 AM
    @User so the multi-vault build ended up taking up my entire day today so I did not get around to moving the DConfig into the next-server ๐Ÿ˜… promise to do it first thing tomorrow. now that being said, this shouldn't block you since
    DendronConfig
    type definitions are in
    common-all
    and it looks like you have the data inside next. in the meanwhile, if you stub the following two methods on the form, I can supply you with the implementation ๐Ÿ™‚
    Copy code
    save(payload: DendronConfig)
    load(): DendronConfig
  • t

    tsnieman

    11/14/2020, 5:43 AM
    No worries, i appreciate the stub! Thank you, enjoy your weekend too โœŒ๏ธ
  • l

    lukecarrier

    11/14/2020, 12:33 PM
    > folks should be able to just import the template they want from inside dendron @User did you have thoughts on the experience for this? Maybe a prompt when creating a vault to select a template from a list of bundled ones?
  • k

    kevins8

    11/14/2020, 3:46 PM
    the way we currently do it: 1) the first time
    initialize workspace is called
    , launch a workspace with the default notes 2) on subsequent calls, add option to either initialize with default notes or an empty workspace a few thoughts. a) i think behavior on
    1)
    is still okay. behavior for
    2)
    can be changed to select from empty vault or one of a template b) when a user adds a vault for multi-vault, do the same behavior as
    a)
  • k

    kevins8

    11/14/2020, 4:44 PM
    @User added stub for config interface. you can find it here: https://github.com/dendronhq/dendron/blob/master/packages/dendron-next-server/pages/workspace/configSample.tsx#L22:L22 the config editor you are working on, I would put it under
    workspace/config.tsx
    . when you're ready for me to take a look, send me a pull request. once we get your changes merged, i will hook it up to our engine backend ๐Ÿ™‚
  • k

    Konrad

    11/14/2020, 9:18 PM
    Hey Folks, before I report is as a bug, is this a known issue? I cannot create scratch notes. When I click on the highlighte blue area with a mouse, or press enter, nothing happens. I tried appending ".hello", but it didn't help.
  • k

    Konrad

    11/14/2020, 9:20 PM
    Creating normal notes works. Creating journal notes also doesn't work.
  • k

    kevins8

    11/14/2020, 9:21 PM
    https://github.com/dendronhq/dendron/issues/346
  • k

    Konrad

    11/14/2020, 9:21 PM
    Yeah, actually, I just saw it ๐Ÿ˜„ thanks
  • k

    kevins8

    11/14/2020, 9:22 PM
    this was just submitted today. can you attach the output of โ€˜dendron: open logsโ€™ after youโ€™ve creating a scratch note?
  • k

    Konrad

    11/14/2020, 9:22 PM
    I will.
  • k

    kevins8

    11/14/2020, 9:22 PM
    also, the server logs which you can access https://www.loom.com/share/a05b0cf597b44e579b77ad76e3af4c07
  • k

    kevins8

    11/14/2020, 9:22 PM
    will be investigating this today!
  • k

    Konrad

    11/14/2020, 9:23 PM
    Awesome, thank you ๐Ÿ™‚
  • k

    Konrad

    11/14/2020, 9:50 PM
    @User just added logs: https://github.com/dendronhq/dendron/issues/346#issuecomment-727269981
  • k

    kevins8

    11/15/2020, 2:14 AM
    @User just updated the issue with a new build. let me know when you get a chance to check it out ๐Ÿ™‚
  • k

    Konrad

    11/15/2020, 2:18 AM
    @User I got "something went wrong". Gathering logs, I will attach them in a sec.
  • k

    Konrad

    11/15/2020, 2:21 AM
    Done!
1...252627...108Latest