https://www.dendron.so/ logo
Join DiscordCommunities
Powered by
# dev
  • k

    kevins8

    08/30/2020, 4:03 AM
    > What do mean "different from actual shortcuts in my fresh install"? @User she means that some of the docs were outdated and had old keyboard shortcuts that were not up to date 😅
  • i

    imalightbulb

    08/30/2020, 4:03 AM
    Ohh
  • i

    imalightbulb

    08/30/2020, 4:03 AM
    Sorry for the misunderstanding
  • i

    imalightbulb

    08/30/2020, 4:04 AM
    Like i can configure ctrl + f for lookup if i want right?
  • i

    imalightbulb

    08/30/2020, 4:04 AM
    As an example
  • u

    user

    08/30/2020, 4:06 AM
    It was like Open preview is ctrl+shift+r Copy note reference is also ctrl+shift+r ))
  • i

    imalightbulb

    08/30/2020, 4:07 AM
    Ohh, that's a problem then
  • j

    jojanaho

    08/31/2020, 6:14 PM
    @User do you encounter the following error if you try to build dendron from a clean checkout:
    Copy code
    src/external/memo/types.ts(1,21): error TS2307: Cannot find module 'vscode-URI' or its corresponding type declarations
  • j

    jojanaho

    08/31/2020, 6:15 PM
    this happens when following the instructions from https://www.dendron.so/notes/64f0e2d5-2c83-43df-9144-40f2c68935aa.html , and executing
    npx lerna run build --scope @dendronhq/engine-server
  • k

    kevins8

    08/31/2020, 6:16 PM
    let me check
  • k

    kevins8

    08/31/2020, 6:21 PM
    just ran from a clean checkout without issues
  • k

    kevins8

    08/31/2020, 6:21 PM
    commit: f6c9238
  • k

    kevins8

    08/31/2020, 6:22 PM
    is that the only error that comes up?
  • k

    kevins8

    08/31/2020, 6:25 PM
    @User are you using vscode and the included
    dendron.code-workspace
    inside dendron to work on dendron? because all projects extend from the root
    tsconfig.json
    , i found that certain typescript config weren't extended if the root wasn't in the
    workspace folders
  • j

    jojanaho

    08/31/2020, 6:27 PM
    hmm, nope - running commands from terminal, dendron root
  • j

    jojanaho

    08/31/2020, 6:28 PM
    sooo... should I run those commands from vscode terminal, and if so, which folder?
  • k

    kevins8

    08/31/2020, 6:29 PM
    its not required. i usually bootstrap using CLI in the root of the dendron repo
  • k

    kevins8

    08/31/2020, 6:29 PM
    you would do the same if you were running inside vscode. i've just noticed that inside vscode, the builtin ts compiler won't pick up on warnings if the root wasn't included as a work folder
  • k

    kevins8

    08/31/2020, 6:29 PM
    but that doesn't sound like the issue here
  • j

    jojanaho

    08/31/2020, 6:30 PM
    hmm, I wonder if you have installed something globally that I don't have?
  • k

    kevins8

    08/31/2020, 6:30 PM
    did you run the bootstrap command at the beginning?
  • j

    jojanaho

    08/31/2020, 6:30 PM
    yep, no errors there
  • k

    kevins8

    08/31/2020, 6:30 PM
    i've installed dendron on multiple computers now, including windows so that shouldn't be it
  • k

    kevins8

    08/31/2020, 6:31 PM
    was plugin-core the only package that resulted in errors?
  • k

    kevins8

    08/31/2020, 6:31 PM
    if you comment out the Uri import and change the references to
    any
    , does it build cleanly?
  • j

    jojanaho

    08/31/2020, 6:38 PM
    yep
  • j

    jojanaho

    08/31/2020, 6:38 PM
    so engine-server was spawning these errors
  • j

    jojanaho

    08/31/2020, 6:41 PM
    looks like I dont have any vscode modules under engine-server/node_modules/@types, but I have those in plugin-core/node_modules/@types
  • j

    jojanaho

    08/31/2020, 6:42 PM
    btw,
    dendron/packages/engine-server/src/external/memo/types.ts
    and
    dendron/packages/plugin-core/src/external/memo/types.ts
    look suspiciously similar but different
  • k

    kevins8

    08/31/2020, 6:44 PM
    you're right - i wanted to move the indexing logic from the plugin into the engine and this is the middle of a bad c/p migration 😦
12345...108Latest