# dev
- k
kevins8
05/24/2022, 4:58 PMalso [[Note Preview|dendron://dendron.docs/pkg.dendron-plugin-views.ref.note-preview]] - g
glucinater21
05/25/2022, 3:11 AMHey I'm trying to contribute to dendron but am having trouble with the setup - g
glucinater21
05/25/2022, 3:12 AMGot this error when trying to do npx yarn setup - s
SeriousBug
05/25/2022, 3:14 AMThis should help I think: https://docs.dendron.so/notes/d0f34b08-0725-4ec5-a600-a4d6309bb2ae#openssl-issuesg- 2
- 25
- g
glucinater21
05/25/2022, 4:53 AMAny recs for a good first issue? - s
SeriousBug
05/25/2022, 4:53 AM - n
Nidoling
05/25/2022, 11:04 PMI'm trying to modify
to be able to accept an async visitor here: https://github.com/dendronhq/dendron/blob/5996538d598f7ad747cb293ef35f58729f8005c3/packages/engine-server/src/markdown/remark/dendronPub.ts#L180 Any tips on how to build a general purpose method that does that?visitParents - s
SeriousBug
05/25/2022, 11:06 PMI think I implemented something like that already, can you check the
in engine? I'm away from my desk so I'm not sure exactly where right now, but I can look it up in a couple hoursdecorators.ts - n
Nidoling
05/25/2022, 11:17 PM@SeriousBug Are you referring to
? https://github.com/dendronhq/dendron/blob/5996538d598f7ad747cb293ef35f58729f8005c3/packages/engine-server/src/markdown/utils.ts#L565 If so, yeup it looks similar to what i want; i'm trying to combine that withvisitAsync
although the current usage atvisitParentsIndices
works with number return types to work with siblings so I was wondering if there was another waydendronPub.ts - s
SeriousBug
05/25/2022, 11:24 PMSorry, I don't have a lot of suggestions. I will suggest keeping the transformations in-order and not parallelizing them (
does this too) because some of the code might rely on the transformations being done in a specific ordervisitAsync - n
Nidoling
05/25/2022, 11:28 PMno worries, i might just try to avoid making this async if it gets too tedious - a
AshSimmonds
05/28/2022, 9:53 AMThere's a
vulnerability reported due to use ofseverity: high
package which hasn't been updated in several years, and as far as I can tell it's only used in Dendron forisomorphic-fetch
which is such an razor's edge case, and can probably be replaced withDropbox.authenticateWithCordova()
if it's still necessary.lquixada/cross-fetch - k
kevins8
05/29/2022, 1:31 AMthanks for the heads up. have a PR to remove it here as we no longer use it > https://github.com/dendronhq/dendron/pull/3002 - k
kevins8
06/04/2022, 1:22 AM@SeriousBug for https://github.com/dendronhq/dendron/blob/master/packages/engine-server/src/workspace/service.ts#L1098 - do you remember why we don't add self contained vaults to config? I'm looking at the setup workspace code and it doesn't look like it adds vaults to the config - s
SeriousBug
06/04/2022, 1:25 AMI'm pretty sure setup workspace does add it to the config. Having it at both places was causing it to be duplicated. I can take a look tonight to find the code if you want - k
kevins8
06/04/2022, 1:28 AMhmm, all good, not urgent. i'll do some digging - k
kevins8
06/04/2022, 3:39 AMno rush to review - just a fyi that i found the issue > https://github.com/dendronhq/dendron/pull/3042 - a
alexis<3
06/06/2022, 8:25 PMis the paste file tool part of the main repo for dendron or is it a 3rd party thing - r
rlh1994
06/06/2022, 8:26 PMPaste image? https://github.com/dendronhq/dendron-paste-image Or something else? - a
alexis<3
06/06/2022, 8:26 PMthere is a function calledpaste file - a
alexis<3
06/06/2022, 8:26 PMi know the paste-image was a 3rd party fork so i was curious if the file was as well - s
SeriousBug
06/06/2022, 8:27 PM - a
alexis<3
06/06/2022, 8:28 PMthanks! im thinking theres a small (probably easy for a TS newb like me) change that would make it more useful. If it could detect common image extensions and drop a
before the linke to render the image! - s
SeriousBug
06/06/2022, 8:31 PMSure! Let us know if you have any questions, otherwise looking forward to a PR 🙂 - s
SeriousBug
06/07/2022, 4:55 AMThe plugin tests in my PR are failing, but the test they fail on doesn't exist in the codebase: https://github.com/dendronhq/dendron/pull/3049 failure: https://github.com/dendronhq/dendron/runs/6764154718?check_suite_focus=true#step:16:3161 There is literally no test nameddecorators are updated - k
kevins8
06/07/2022, 4:03 PMhave you updated the ci.yml cache key? this happens sometimes when old tests are deleted but are still in the cache - n
Nidoling
06/08/2022, 12:22 AMSince NoteProps is unique on id and (fname+vault+wsroot), does it make sense to overload
to support both types?engine.getNote - s
SeriousBug
06/08/2022, 7:55 PMI tried doing so (twice), but it still looks like the tests are failing. - k
kevins8
06/08/2022, 7:57 PMis this the test in question? https://github.com/dendronhq/dendron/blob/master/packages/plugin-core/src/test/suite-integ/WindowWatcher.test.ts#L45:L45 - s
SeriousBug
06/08/2022, 7:58 PMHmm, let me try merging master again. I tried it, but maybe that test wasn't included.