https://www.dendron.so/ logo
Join Discord
Powered by
# dev
  • d

    Dillon // dleetr

    04/21/2022, 3:02 AM
    I opened the
    dendron-main.code-workspace
    and ran into this which I've never seen before...what even am I supposed to enter in this box? Edit: Not sure what I'm meant to enter into the box, SO has me on a path to a fix though (ssh needs to be configured)
  • s

    SeriousBug

    04/21/2022, 3:49 AM
    That shouldn't be related to Dendron, did you install any git related extensions recently? My bad responded without checking what channel it is
  • s

    SeriousBug

    04/21/2022, 3:50 AM
    You can probably just say cancel. I think Dendron is trying to clone the docs repositories, but you don't have ssh set up so it fails. Everything should work in terms of developing dendron
  • d

    Dillon // dleetr

    04/21/2022, 4:12 AM
    Yea the next time it asked for my gh pw to auth
  • n

    Nidoling

    04/21/2022, 9:35 PM
    I'm seeing
    Attempted to wrap homedir which is already wrapped
    errors for my .spec tests. Any theories why my changes may have caused these? https://github.com/dendronhq/dendron/runs/6119531929?check_suite_focus=true
  • n

    Nidoling

    04/22/2022, 5:46 PM
    Just thinking out loud, but is it possible for the tests (engine.spec and enginev2.spec) to interfere with each other when we run in parallel with respect to the sinon stubs
  • k

    kevins8

    04/22/2022, 5:57 PM
    saw that too - haven't had a chance to investigate yet
  • k

    kevins8

    04/22/2022, 5:57 PM
    they shouldn't - if that were the case we would see a lot more issues
  • k

    kevins8

    04/22/2022, 5:57 PM
    can you look at the master branch and see when we started seeing these errors?
  • k

    kevins8

    04/22/2022, 5:58 PM
    that should narrow down which commit caused it
  • n

    Nidoling

    04/22/2022, 6:01 PM
    No worries. I saw it a few times in the past but its consistent with my current pr so there might be another underlying issue with my code. i wonder if the true error is masked by this error message. i'm also still investigating
  • n

    Nidoling

    04/22/2022, 6:10 PM
    Also worth noting that
    npx lerna run test --ignore @dendronhq/plugin-core --ignore @dendronhq/nextjs-template --parallel --stream -- -- --forceExit
    passes on local laptop. Just saw "A worker process has failed to exit gracefully and has been force exited" but that has been there in past
  • k

    kevins8

    04/22/2022, 6:21 PM
    got it. usually we see issues in gh runners because the containers aren't very beefy so tests will timeout which will cause casecading failures
  • n

    Nidoling

    04/22/2022, 6:44 PM
    gotcha. it looks likes if one test fails, it doesn't cleanup the stubs leading to the "attempted to wrap" errors. so really I should be looking at the top for the first test failure case. Looks like i have a lead now
  • k

    kevins8

    04/22/2022, 6:45 PM
    yeah, i was just going to mention that
  • k

    kevins8

    04/22/2022, 6:45 PM
    fresh repro -> https://github.com/dendronhq/dendron/runs/6133346735?check_suite_focus=true
  • k

    kevins8

    04/22/2022, 6:45 PM
    it looks like a timeout
  • k

    kevins8

    04/22/2022, 6:46 PM
    we might just want to set timeout for engine test to 10s given that we are running
    init
    inside of it 2x now
  • n

    Nidoling

    04/22/2022, 6:49 PM
    mkay. looks like i have an actual bug with mine thats separate than timeout. as for the
    init
    , can we remove the init from
    createEngineFromServer
    in
    engine.ts
    ?
  • k

    kevins8

    04/22/2022, 6:54 PM
    do you have some code you can point to? depends on the ctx
  • n

    Nidoling

    04/22/2022, 6:56 PM
    This line https://github.com/dendronhq/dendron/blob/2bb884f0468f2912555e4c5b039716d27b6cf4ad/packages/engine-test-utils/src/engine.ts#L108
  • k

    kevins8

    04/22/2022, 7:00 PM
    thats needed for how the api engine tests are setup
  • k

    kevins8

    04/22/2022, 7:00 PM
    is it causing an issue?
  • n

    Nidoling

    04/22/2022, 7:02 PM
    it could cause timeouts as you mentioned since we run init twice (here and https://github.com/dendronhq/dendron/blob/2bb884f0468f2912555e4c5b039716d27b6cf4ad/packages/engine-test-utils/src/engine.ts#L326) The second one should be enough?
  • k

    kevins8

    04/22/2022, 7:10 PM
    hmm, yeah your right. i haven't swept through all invocations yet but you can try removing and see if that breaks anything 😅
  • n

    Nidoling

    04/22/2022, 7:14 PM
    Oh I thought you were referring to that already from this lol. Is there somewhere else where we run
    init
    2x?
  • k

    kevins8

    04/22/2022, 7:45 PM
    shouldn’t be
  • a

    aleksey

    04/25/2022, 11:53 AM
    Have you considered replacing the current calendar view with something like this contribution graph/weather map? To me, the current calendar doesn't provide a good overview and switching months/years is somewhat cumbersome (also, if you switch to a month with no daily note on that day, it would auto-create it, which is not exactly what I expect).
  • j

    jyeung

    04/25/2022, 12:05 PM
    Tagging @Joshi to this thread as we were just chatting about some different viz options
  • f

    foureyedsoul

    04/25/2022, 9:50 PM
    If you're thinking of other options, an option I think would be useful would be to have it configurable for weekly & monthly notes as well as daily ones. @Joshi My own smallest journal notes are almost always weekly notes. It would be really nice to be able to have a ISO 8601-style week number on the calendar view that jumps to that week's note. Each day on the calendar ideally could also link to the heading of that weekly note. No idea how complex that would be "behind the scenes," but it's a "quality of life" feature I've often wanted.
1...99100101...108Latest