https://venicedb.org logo
Join Slack
Powered by
This message was deleted.
# general
s
This message was deleted.
f
Hmm... it is intended to be valid 😅 we'll fix it if not. Would you mind pointing out the issues you're finding?
d
For start, 
create_store
script (Venice client) can't be invoked without arguments as suggested by the document. 
batch_push_data
and 
query_data
scripts are missing, though they might be renamed to 
run_vpj
and 
fetch
, respectively. Both of those scripts require arguments.
f
@Sushant Mane, @Manoj Nagarajan, would be great to check that out and make sure the quickstart is still functional 🙏
s
If you're using docker-compose.yml for single-region setup, please follow: https://venicedb.org/docs/quickstart/quickstart-single-datacenter and for multi-region setup use: https://venicedb.org/docs/quickstart/quickstart-multi-datacenter. IMO these guides are still valid. It's just that script from one setup won't work with other.
d
I am using a single data center and it doesn't work for the reasons stated above. If there is an alternative way to run the script, please let me know.
s
Oh I see. I just followed multi-region setup and everything works fine. Let me try out single dc setup
👍 1
d
Thank you
s
Followed: https://github.com/linkedin/venice/blob/main/docker/docker-compose-single-dc-setup.yaml for single colo setup and everything still works.
d
So you are able to execute all of the steps that come after compose up?
s
Yeah
Can you share the error you're seeing?
d
I guess I am using something else.
Yes: missing arguments
That is the error I am facing as creation script requires arguments
s
Except for 
query_data.sh
no other script takes arguments
Copy code
bash create_store.sh # no arg needed
d
I don't even see query data script
And the create store requires arguments
I am using the scripts present inside venice-client container
s
The above script is for single colo setup. Are you using locally built docker images? The following images is from venice-client container of single-colo (
latest
tagged venice image)
d
No
I have a completely different layout
s
That being said it does look like we can improve this setup (and could likely be broken though I'm not able to repro it yet)
what's the version of docker images in your case?
d
Let me get back home and I'll share all the details
I pulled the images a few hours ago using the provided compose
So it should be "latest"
Or, whatever is tagged as such
s
Sounds good. I'll go through docker compose today to make both single colo and multi colo setups consistent. Until then could you give shot to multi-dc setup?
✅ 1
I think I found the problem.
Single colo setup images tagged with 
0.4.85
are broken. So if you use: https://github.com/linkedin/venice/blob/main/docker/docker-compose-single-dc-setup.yaml for single dc the steps won't work. But 
0.4.17
images still work. For some reason 
latest
on my setup I didn't see the issue
I'll fix this. Thanks for bringing it up!
d
Thank you, I'll confirm it in a few minutes
s
SG, thanks
d
I can confirm that the latest resolves to 0.4.85.
I'll drop the 
latest
references from compose, and specify explicit, working versions for now.
s
Wait.. it's possible on my setup latest tagged images are from local cache.. and even 0.4.17 is broken
d
Ok 🙂
s
for now can you continue with multi colo setup
it should work. You can still use single colo setup with direct access to venice admin jars if you want
d
I can confirm that the steps in the multi-datacenter quickstart guide work (0.4.85 in use). It looks like the single-datacenter guide script usage should be corrected (i.e., add the arguments). I will test if it works once invoked properly.
I can confirm that the single-datacenter guide also works once the scripts are invoked with arguments (the part that I reported as missing). For example, instead of the docs suggestion:
Copy code
bash create_store.sh
One should do:
Copy code
./create-store.sh <http://venice-controller:5555> venice-cluster0 test-store sample-data/schema/keySchema.avsc sample-data/schema/valueSchema.avsc
I can submit a pull request with the docs fixes if that's ok.
gratitude thank you 1
f
Sounds great, a PR is certainly welcome! Thanks Dejan! And sorry for the confusion!
d
No worries, I'll prepare the PR a bit later! Thank you both for checking out the issue 🙂
🤝 2
gratitude thank you 1
f
Thanks for the PR! The fix is merged and the new docs are published! https://venicedb.org/docs/quickstart/quickstart-single-datacenter
🙌 2
gratitude thank you 1
2 Views
Open in Slack
PreviousNext
Powered by