This message was deleted.
# general
s
This message was deleted.
z
I'm not sure I understand the question. It sounds like the crux is over hesitation of submitting a large PR?
I guess that's not something we generally encourage... But admittedly for my part, I think I'd be interested in seeing the grizzly details. Is all this in a branch I can look at today?
e
This is our fork 🙂 https://github.com/datastax/venice
There a a few things that I don’t like much, like very poor code coverage for the new stuff) but before moving forward I need to be in sync with you.
The other big thing that I don’t like much is that I had to hard code “token” everywhere in the APIs and internals.
apart from that it works like a charm 🙂 we have end-to-end tests on k8s that cover the basic workflows for us
I am now working on abstracting the client side part (so “token” will no more be hard coded, but a generic “ClientAuthenticationProvider” interface)
(tomorrow I will have removed all the hard coded “token” parameters)
@Zac Policzer probably I have to add this ClientAuthenticationProvider to VIP-1, but I didn’t want to make it (VIP-1) too big
My patch has been committed to DataStax fork.