This message was deleted.
# generals
Slackbot
05/02/2023, 6:50 PMThis message was deleted.
f
Felix GV
05/02/2023, 6:52 PMWhat I’m gathering:
1. Using GH issues is not ideal, PR to write a MD file into the repo is preferred.
2. Using emails with GH issues is challenging. Unclear if email with PR is much better. In the case of Venice, we don’t even have a mailing list and I’m not sure we should have one, so maybe we can avoid this particular headache.
m
Manu
05/02/2023, 7:52 PMI was thinking about a few of these thoughts going through the PIP proposal.
+1 for PR to write an MD file.
e
Enrico Olivelli
05/02/2023, 8:57 PMLet's do it with the MD file + PR
👍 2
m
Manu
05/03/2023, 11:36 PMHere is an initial proposal draft for what we discussed.
https://github.com/linkedin/venice/pull/396
f
Felix GV
05/04/2023, 12:45 AMThanks a lot for acting on it quickly Manu! I left a few comments.
🤝 1
e
Enrico Olivelli
05/05/2023, 10:18 AMGreat
f
Felix GV
05/05/2023, 12:52 PMPlease comment if you have suggestions on the process @Enrico Olivelli
e
Enrico Olivelli
05/06/2023, 6:13 AMI started to take a look, but I am not done with my review. I will post my comments early next week
Enrico Olivelli
05/08/2023, 10:13 AMI posted my comments
🙏 1
f
Felix GV
05/08/2023, 11:18 AMI see one comment about the alternatives stuff. Did you intend to post more?
Felix GV
05/08/2023, 3:41 PM(Just wondering since you said “comments” plural… forgot to click submit perhaps?)
e
Enrico Olivelli
05/08/2023, 3:57 PMnothing more
Enrico Olivelli
05/08/2023, 3:58 PMthanks for double checking
Enrico Olivelli
05/09/2023, 8:00 AMCould we merge the VIP template ?
I posted a final comment
https://github.com/linkedin/venice/pull/396
I am eager to start writing “VIP-1 Pluggable Authentication Service for VeniceDB” 😉
m
Manu
05/09/2023, 3:57 PMYes! Good point on iterating as we go. We don't need to be perfect and I am excited that we will have a proposal ready to go right at the auth! Safety first!
Manu
05/09/2023, 4:01 PMThere are 3 items pending
1. Landing page for the list of Accepted, Rejected and InDiscussion proposals.
2. Line width of 80 chars enforced by spotless.
3. Define the Voting process
I propose we merge the existing PR so that contributions can kickstart and these 2 items can be done as a follow up PR.
e
Enrico Olivelli
05/09/2023, 4:18 PM👍
f
Felix GV
05/09/2023, 7:35 PMSorry for the wait, I’ve been distracted with some other work. I agree, let’s get started with this and improve iteratively as we go. Cheers!
m
Manu
05/09/2023, 11:03 PMAll is clean on that PR, can you please help merge this @Felix GV (I don't have write privileges)
f
Felix GV
05/09/2023, 11:35 PMThe VIP process is merged! Who wants to claim #vip-1 😁 ?
🤝 2
4 Views